Add finalized flag to API responses

[rkapka]

🚀 Feature Request

We need to implement ethereum/beacon-APIs#254

Description

Several API endpoints must return a finalized metadata field. This issue tracks progress of the feature:

• https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getBlockAttestations
• https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getBlindedBlock
• https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getBlockV2
• https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getBlockHeaders
• https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getBlockHeader
• https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getBlockRoot
• https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getEpochCommittees
• https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getStateFinalityCheckpoints
• https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getStateFork
• https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getStateRandao
• https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getStateRoot
• https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getEpochSyncCommittees
• https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getStateValidators
• https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getStateValidator
• https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getStateValidatorBalances
• https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Debug/getStateV2

[thearyanag]

Hey @rkapka can you please assign this issue to me ?

[rkapka]

Hi @thearyanag , sure. I already implemented all block endpoints. You can take care of the state ones.

[rkapka]

There is a way to avoid calling HashTreeRoot on the block to check finalization. The algorithm works as follows:

you check the parent root, if it equals the finalized checkpoint you return false. If not then you check if the parent is final. If it is then you return true, otherwise false. This assumes that the block is canonical. If it's not then return false

[thearyanag]

Hey thanks for the heads up , on it now , was actually figuring out that only/ Regards , aryan

…

On Mon, 19 Dec 2022 at 19:33, Radosław Kapka ***@***.***> wrote: There is a way to avoid calling HashTreeRoot on the block to check finalization. The algorithm works as follows: you check the parent root, if it equals the finalized checkpoint you return false. If not then you check if the parent is final. If it is then you return true, otherwise false. This assumes that the block is canonical. If it's not then return false — Reply to this email directly, view it on GitHub <#11747 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALRGJWOTGGODSB5ZZJH2EILWOBTJPANCNFSM6AAAAAASYQ64VA> . You are receiving this because you were assigned.Message ID: ***@***.***>