Skip to content

Commit

Permalink
Empty Committee Check in Submit Attestation (#5672)
Browse files Browse the repository at this point in the history
* empty committee check
* Merge refs/heads/master into validator-id-errs
  • Loading branch information
rauljordan authored Apr 29, 2020
1 parent 9415519 commit 3b2c514
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 1 deletion.
4 changes: 4 additions & 0 deletions validator/client/validator_attest.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@ func (v *validator) SubmitAttestation(ctx context.Context, slot uint64, pubKey [
}
return
}
if len(duty.Committee) == 0 {
log.Debug("Empty committee for validator duty, not attesting")
return
}

v.waitToSlotOneThird(ctx, slot)

Expand Down
18 changes: 17 additions & 1 deletion validator/client/validator_attest_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,23 @@ func TestRequestAttestation_ValidatorDutiesRequestFailure(t *testing.T) {
testutil.AssertLogsContain(t, hook, "Could not fetch validator assignment")
}

func TestAttestToBlockHead_SubmitAttestationRequestFailure(t *testing.T) {
func TestAttestToBlockHead_SubmitAttestation_EmptyCommittee(t *testing.T) {
hook := logTest.NewGlobal()

validator, _, finish := setup(t)
defer finish()
validator.duties = &ethpb.DutiesResponse{Duties: []*ethpb.DutiesResponse_Duty{
{
PublicKey: validatorKey.PublicKey.Marshal(),
CommitteeIndex: 0,
Committee: make([]uint64, 0),
ValidatorIndex: 0,
}}}
validator.SubmitAttestation(context.Background(), 0, validatorPubKey)
testutil.AssertLogsContain(t, hook, "Empty committee")
}

func TestAttestToBlockHead_SubmitAttestation_RequestFailure(t *testing.T) {
hook := logTest.NewGlobal()

validator, m, finish := setup(t)
Expand Down

0 comments on commit 3b2c514

Please sign in to comment.