Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving validator key validation #237

Merged
merged 4 commits into from
Oct 18, 2022
Merged

Improving validator key validation #237

merged 4 commits into from
Oct 18, 2022
+51 −25

Conversation

james-prysm
Copy link
Contributor

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

  • Validator keys that use the same password was spinning up too many validation requests which were leading to OOM on the instance which lead to crashes. We attempt to solve this by grouping the validator request into a single request for processing.
  • the continue button was also changing to enabled status while the validator form was still in pending status.

Which issues(s) does this PR fix?

Fixes #11544

Other notes for review

@james-prysm james-prysm added the bug Something isn't working label Oct 18, 2022
@james-prysm james-prysm self-assigned this Oct 18, 2022
@james-prysm james-prysm marked this pull request as ready for review October 18, 2022 20:34
@james-prysm james-prysm merged commit bb453e0 into master Oct 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the oom-fix branch October 18, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

Assignees

@james-prysm james-prysm

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james-prysm @rauljordan