Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an .nvmrc #130

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Add an .nvmrc #130

merged 2 commits into from
Jan 21, 2021

Conversation

icco
Copy link
Contributor

@icco icco commented Dec 20, 2020

Sets a default node version for the project. Useful for those who use NVM and may have many versions of node on their system.

Sets a default node version for the project
@CLAassistant
Copy link

CLAassistant commented Dec 20, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@mohamedmansour mohamedmansour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, another useful place to put it would be in package.json under engines:

{ "engines" : { "node" : ">=14" } }

I had to upgrade my node to v14 to compile this webui too.

@rauljordan rauljordan merged commit 9e44f1c into prysmaticlabs:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants