Add Validator Indices to Queue/Committee Instead of Public Keys #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
approved these changes
Apr 22, 2020
|
I approve removing public keys from these rtypes of request to reduce the size of the response. We can remove these fields entirely as we promote to v1alpha2 or v1beta1 |
prestonvanloon
added a commit
to prestonvanloon/eth2-beaconchain-explorer
that referenced
this pull request
Apr 25, 2020
prestonvanloon
added a commit
to prysmaticlabs/prysm
that referenced
this pull request
Apr 25, 2020
…alidator index return field
prylabs-bulldozer bot
pushed a commit
to prysmaticlabs/prysm
that referenced
this pull request
Apr 25, 2020
* Update EthereumAPIs to prysmaticlabs/ethereumapis#137 and implement validator index return field
peterbitfly
pushed a commit
to gobitfly/eth2-beaconchain-explorer
that referenced
this pull request
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #131 and resolves #132. We add validator indices to common response types such as committee assignments and the validator queue as they are cheaper to compute than public keys and are not as useful. We mark the public key fields as deprecated instead of deleting them for now.