Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 🙌
I think those specs are failing because Dir.glob is not being found over the C docs yard was generated from.
Investigating why I saw that Dir.glob was moved into
dir.rb
and removed fromdir.c
on the following commit ruby/ruby@60e25e3#diff-7b6c9d59e98b433bac23d954cfeb47fb25e36e93cdad448ffa777612fb52cc52Changing this spec to a method still defined in C would make those specs pass and that could unblock the release?
Ideally for other
$ Dir.glob
and other methods moved for .rb files to work like it was on 2.7 there is a little bit more work. For example, adding those dir.rb and other files do the yardoc generation. I can investigate a bit more. Would that make sense?