Add MCU_MAXTEMP_ERR #112
Merged
Add MCU_MAXTEMP_ERR #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure if we want to propagate string value about specific name of MCU for MINI, MK4 and iX since they have only one MCU |
|
I thought about that, but the code would be more complicated as it would have to know if this printer has |
|
would it be better to add verb to "MCU in %s overheated."? |
|
yeah you are correct about that so lets leave it universal |
tomasjakubik
force-pushed
the
mcu-maxtemp-err
branch
from
28f56b9
to
ac122f8
Compare
davidnovacek
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.