[PPS] Added a method to get a detailed meeting report #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prschmid
requested changes
May 6, 2020
There was a problem hiding this comment.
Thank you for taking the time to make an addition to the library! Can you please write a test case for it?
A bunch of things are getting merged in to develop, so please make sure to merge in the most recent develop before you submit for the next round of review. Thank you for your time and effort!
| @@ -41,6 +41,15 @@ def get_user_report(self, **kwargs): | |||
| "/report/users/{}/meetings".format(kwargs.get("user_id")), params=kwargs | |||
| ) | |||
|
|
|||
| def get_meeting_detail_report(self, **kwargs): | |||
There was a problem hiding this comment.
Thank you for this addition! Can you please add a test case for it so that we can ensure that we are maintaining test coverage?
Thank you for your time and effort!
|
Hi, noob question but how do I join a meeting with it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a requirement for my company, but sharing here as well