Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Grunt tasks and Minor CSS improvements #2

Merged
merged 3 commits into from
Nov 2, 2014

Conversation

abpetkov
Copy link
Contributor

@abpetkov abpetkov commented Nov 2, 2014

Hi. I like your plugin very much and decided to do few changes to make the dev process better.

  • I added Grunt tasks. Run npm install (with Node.js installed) to install dependencies. Then running grunt or grunt build will generate minified JS and CSS files into the min/ directory using src/ directory as a source.
  • In your main CSS file I changed the padding property for .jq-ry-container to use more shorthand syntax. Also you don't need to specify px or % units for zero values.
  • Fixed a small typo in the Readme

Some advices:

  • You might want to publish this in Bower. It will help you popularize your project at least a little.
  • Check out Semver and use it for versioning your project. It's a good and popular practice and will be appreciated.

Cheers.

prrashi added a commit that referenced this pull request Nov 2, 2014
Basic Grunt tasks and Minor CSS improvements
@prrashi prrashi merged commit 8cb360a into prrashi:master Nov 2, 2014
@prrashi
Copy link
Owner

prrashi commented Nov 2, 2014

@abpetkov Thanks a lot :), i shall update in bower too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants