Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rules_rust to latest. #92

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Update rules_rust to latest. #92

merged 2 commits into from
Mar 16, 2021

Conversation

PiotrSikora
Copy link
Member

Signed-off-by: Piotr Sikora [email protected]

@PiotrSikora
Update rules_rust to latest.
d7da375 
Signed-off-by: Piotr Sikora <[email protected]>
@PiotrSikora PiotrSikora requested a review from mathetake March 15, 2021 19:34
@mathetake
Copy link

mathetake commented Mar 16, 2021 •
edited
Loading

I see that now rust.bzl is deprecated and we are recommended to use defs.bzl.

https://github.com/bazelbuild/rules_rust/blob/main/rust/rust.bzl#L15

@PiotrSikora
Copy link
Member Author

I see that now rust.bzl is deprecated and we are recommended to use defs.bzl.

https://github.com/bazelbuild/rules_rust/blob/main/rust/rust.bzl#L15

Thanks for noticing this! Unfortunately, cargo-raze doesn't support it yet (see: google/cargo-raze#398), so I'd prefer to wait for it, instead of having mixed use of rust.bzl and defs.bzl in the same repository.

mathetake
mathetake approved these changes Mar 16, 2021
View reviewed changes
Copy link

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so I'd prefer to wait for it, instead of having mixed use of rust.bzl and defs.bzl in the same repository.

OK, that makes sense. LGTM!

@PiotrSikora PiotrSikora merged commit c5a72ca into proxy-wasm:master Mar 16, 2021
nullpo-head pushed a commit to nullpo-head/proxy-wasm-rust-sdk that referenced this pull request Apr 20, 2021
@PiotrSikora @nullpo-head
Update rules_rust to latest. (proxy-wasm#92)
2e3bc64 
Signed-off-by: Piotr Sikora <[email protected]>
nullpo-head pushed a commit to nullpo-head/proxy-wasm-rust-sdk that referenced this pull request Apr 20, 2021
@PiotrSikora @nullpo-head
Update rules_rust to latest. (proxy-wasm#92)
7bc2e18 
Signed-off-by: Piotr Sikora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathetake mathetake mathetake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PiotrSikora @mathetake