Bug fix, a few net changes #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made network code a little more idempotent. Added replay of events that occur during init but the state is not there to act on. Removed timer to wait for a leader to emerge, since replay makes that bodge unecessary. Added more protective code around frames that were assumed to always exist, but it turns out asynchronicity has a way of changing that. Pruned the raid code of all the info collection it turned out was not needed or there was a better way to get at it. Fixed protocol around destination and at destination to maintain the at dest list properly, there was also a bug around Caught some places that operated on the waiting table directly and funnelled them through existing methods, or created them. Made the disconnect message clear that its disconnecting the client from the addon network. Simplified protocol around destination now that more rigorous checks are made before reporting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made network code a little more idempotent.
Added replay of events that occur during init but the state is not there to act on. Removed timer to wait for a leader to emerge, since replay makes that bodge unecessary.
Added more protective code around frames that were assumed to always exist, but it turns out asynchronicity has a way of changing that.
Pruned the raid code of all the info collection it turned out was not needed or there was a better way to get at it.
Fixed protocol around destination and at destination to maintain the at dest list properly, there was also a bug around
Caught some places that operated on the waiting table directly and funnelled them through existing methods, or created them.
Made the disconnect message clear that its disconnecting the client from the addon network.
Simplified protocol around destination now that more rigorous checks are made before reporting.