Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aurora): Add default ports to the check of using non default ports #5821

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

madslundholmdk
Copy link

@madslundholmdk madslundholmdk commented Nov 19, 2024

Context

When using Aurora RDS clusters/instances, they are marked as using non-default port, even though the default port are in use.

Description

The Aurora engines has been added to the list of default ports to the respective default port.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@madslundholmdk madslundholmdk requested review from a team as code owners November 19, 2024 07:07
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Nov 19, 2024
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @madslundholmdk thank you for this fix! Could you please add some tests to cover it? I can help you if you need guidance.

@jfagoagas jfagoagas changed the title Add Aurora default ports to the check of using non default ports fix(aurora): Add default ports to the check of using non default ports Nov 19, 2024
@jfagoagas jfagoagas self-assigned this Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.88%. Comparing base (f01ce84) to head (b29ed86).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5821      +/-   ##
==========================================
- Coverage   89.91%   89.88%   -0.03%     
==========================================
  Files        1133     1133              
  Lines       35308    35308              
==========================================
- Hits        31747    31738       -9     
- Misses       3561     3570       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@madslundholmdk
Copy link
Author

Hi @jfagoagas
I'm happy to be able to help with this project.

I have now added a couple of tests to ensure it's working as expected.

@jfagoagas
Copy link
Member

@madslundholmdk Thank you!

One question, are you using the pre-commit since I see several lint steps failing, could you please follow this guide https://docs.prowler.com/projects/prowler-open-source/en/latest/developer-guide/introduction/#contributing-with-your-code-or-fixes-to-prowler? I can help you if you encounter any issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants