Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(neptune): add new fixer neptune_cluster_public_snapshot_fixer #5749

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

danibarranqueroo
Copy link
Member

@danibarranqueroo danibarranqueroo commented Nov 13, 2024

Context

Developed a new fixer that modifies the snapshot settings of Neptune clusters to ensure they are private and not publicly accessible. This will help prevent unauthorized access to database snapshots, enhancing the security of stored data and reducing the risk of data leaks.

For the unit tests, moto does not work well with Neptune so I had to use Botocore.

Description

Added new fixer neptune_cluster_public_snapshot_fixer with its unit tests.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Nov 13, 2024
@danibarranqueroo danibarranqueroo changed the title feat(neptune): add new fixer feat(neptune): add new fixer neptune_cluster_public_snapshot_fixer Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.89%. Comparing base (f3cfaca) to head (befe49d).
Report is 25 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #5749    +/-   ##
========================================
  Coverage   89.89%   89.89%            
========================================
  Files        1128     1133     +5     
  Lines       35182    35285   +103     
========================================
+ Hits        31628    31721    +93     
- Misses       3554     3564    +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant