Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k8s): do not raise error when unable to list roles #5630

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

MrCloudSec
Copy link
Member

@MrCloudSec MrCloudSec commented Nov 4, 2024

Context

When scanning from remote, the users don't have permissions to list all clusterrolebindings.

Fix #5452 (reply in thread).

Description

Low the error severity and do not raise an error when Prowler doesn't have permissions to list all clusterrolebindings.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested review from a team as code owners November 4, 2024 18:02
@github-actions github-actions bot added the provider/kubernetes Issues/PRs related with the Kubernetes provider label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.79%. Comparing base (694cee1) to head (272de92).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...rowler/providers/kubernetes/kubernetes_provider.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5630      +/-   ##
==========================================
+ Coverage   89.77%   89.79%   +0.01%     
==========================================
  Files        1111     1111              
  Lines       34468    34466       -2     
==========================================
+ Hits        30944    30949       +5     
+ Misses       3524     3517       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCloudSec MrCloudSec merged commit 230d257 into master Nov 4, 2024
10 of 11 checks passed
@MrCloudSec MrCloudSec deleted the fix-k8s-roles branch November 4, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/kubernetes Issues/PRs related with the Kubernetes provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants