Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compliance): New AWS Performance Pillar Framework #3170

Conversation

akshat-crypto
Copy link

@akshat-crypto akshat-crypto commented Dec 7, 2023

Context

To add a new customized pillar in AWS Well Architected Framework

Description

There are almost 6 AWS Well Architected Review Pillars we can use , I am currently adding Performance Pillar to test how this will work, and based on the review, we can create multiple custom checks

@akshat-crypto akshat-crypto requested a review from a team December 7, 2023 17:44
@jfagoagas jfagoagas added the no-merge Please, DO NOT MERGE this PR. label Dec 11, 2023
@jfagoagas jfagoagas changed the title Performance pillar framework feat(compliance): New AWS Performance Pillar Framework Dec 11, 2023
@jfagoagas jfagoagas added the provider/aws Issues/PRs related with the AWS provider label Dec 11, 2023
Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for you PR! here’s my first review:

Let me know if you need help with any of this points 😄

Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve just fix a typo in the name of your metadata file. Please, do the following changes:

  • revert the changes done on the awslambda_function_not_publicly_accessible check
  • the logic of serverless_architecture in the Lambda Service is needed
  • the logic of is_instance_type_optimized in the EC2 Service is needed

We can have a quick call if you need help 🙂

@MrCloudSec
Copy link
Member

Hi @akshat-crypto , do you need help on adding the needed logic in the services?

@jfagoagas jfagoagas changed the base branch from master-v3 to v3 April 8, 2024 06:36
@jfagoagas jfagoagas marked this pull request as draft August 2, 2024 06:04
@jfagoagas
Copy link
Member

jfagoagas commented Aug 5, 2024

Hello @akshat-crypto we will close this PR. We have created this issue #4638 to keep track of the AWS Performance Pillar Framework implementation. We will use the work you did which is fantastic to complete the missing code from the review that @sergargar did.

Thank you for contributing with Prowler!

@jfagoagas jfagoagas closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-merge Please, DO NOT MERGE this PR. provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants