-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compliance): New AWS Performance Pillar Framework #3170
feat(compliance): New AWS Performance Pillar Framework #3170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for you PR! here’s my first review:
- the metadata for the check
ec2_instance_type_optimized
is missing (https://docs.prowler.cloud/en/latest/developer-guide/checks/#check-metadata) - the logic of
serverless_architecture
in the Lambda Service is needed - the logic of
is_instance_type_optimized
in the EC2 Service is needed - please, restore the changes in the
banner.py
file
Let me know if you need help with any of this points 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve just fix a typo in the name of your metadata file. Please, do the following changes:
- revert the changes done on the
awslambda_function_not_publicly_accessible
check - the logic of
serverless_architecture
in the Lambda Service is needed - the logic of
is_instance_type_optimized
in the EC2 Service is needed
We can have a quick call if you need help 🙂
28f1764
to
bce1f02
Compare
bce1f02
to
44c0417
Compare
Hi @akshat-crypto , do you need help on adding the needed logic in the services? |
Hello @akshat-crypto we will close this PR. We have created this issue #4638 to keep track of the AWS Performance Pillar Framework implementation. We will use the work you did which is fantastic to complete the missing code from the review that @sergargar did. Thank you for contributing with Prowler! |
Context
To add a new customized pillar in AWS Well Architected Framework
Description
There are almost 6 AWS Well Architected Review Pillars we can use , I am currently adding Performance Pillar to test how this will work, and based on the review, we can create multiple custom checks