-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the marker module to fix the bank SendEnabled issue. #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…contains the bank fix.
…ists in the devtools makefile. The one in the devtools makefile specifies a version and prevents updating the go.mod and go.sum files, so that one is preferable.
…addition of the restricted field to the name queries.
Codecov Report
@@ Coverage Diff @@
## main #850 +/- ##
==========================================
- Coverage 55.99% 55.94% -0.05%
==========================================
Files 179 179
Lines 22045 22002 -43
==========================================
- Hits 12343 12308 -35
+ Misses 8758 8751 -7
+ Partials 944 943 -1
|
dwedul-figure
requested review from
iramiller,
channa-figure,
arnabmitra,
derekadams,
egaxhaj and
Taztingo
as code owners
June 6, 2022 22:18
iramiller
reviewed
Jun 6, 2022
iramiller
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
derekadams
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8 tasks
4 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v0.45.4-pio-1
, which contains the bank module'sSendEnabled
fix.SendEnabled
entries.Makefile
devtool cleanup with due togo
changes.restricted
field to name queries.third_party
bank protos.Related to Cosmos-SDK issue: 11859
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes