Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the marker module to fix the bank SendEnabled issue. #850

Merged
merged 14 commits into from
Jun 7, 2022

Conversation

dwedul-figure
Copy link
Contributor

@dwedul-figure dwedul-figure commented Jun 6, 2022

Description

  1. Bump Cosmos-SDK to v0.45.4-pio-1, which contains the bank module's SendEnabled fix.
  2. Update the marker module to correctly manage the SendEnabled entries.
  3. Some Makefile devtool cleanup with due to go changes.
  4. Regenerate swagger config. It only includes the change that added the restricted field to name queries.
  5. Update the third_party bank protos.

Related to Cosmos-SDK issue: 11859


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #850 (e68142f) into main (2fe84d9) will decrease coverage by 0.04%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
- Coverage   55.99%   55.94%   -0.05%     
==========================================
  Files         179      179              
  Lines       22045    22002      -43     
==========================================
- Hits        12343    12308      -35     
+ Misses       8758     8751       -7     
+ Partials      944      943       -1     
Impacted Files Coverage Δ
app/upgrades.go 7.87% <ø> (+0.29%) ⬆️
x/marker/keeper/marker.go 51.96% <66.66%> (-2.45%) ⬇️
x/marker/keeper/keeper.go 84.74% <100.00%> (ø)

x/marker/keeper/marker.go Outdated Show resolved Hide resolved
x/marker/keeper/marker.go Outdated Show resolved Hide resolved
@dwedul-figure dwedul-figure enabled auto-merge (squash) June 7, 2022 00:46
Copy link
Member

@iramiller iramiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@derekadams derekadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwedul-figure dwedul-figure merged commit 388fe28 into main Jun 7, 2022
@dwedul-figure dwedul-figure deleted the dwedul/bank-send-fix branch June 7, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants