616 add attribute max length change #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
channa-figure
requested review from
arnabmitra,
dwedul-figure,
egaxhaj,
fkneeland-figure and
iramiller
as code owners
Codecov Report
@@ Coverage Diff @@
## main #623 +/- ##
==========================================
- Coverage 56.59% 56.49% -0.11%
==========================================
Files 174 173 -1
Lines 20904 20834 -70
==========================================
- Hits 11831 11770 -61
+ Misses 8164 8161 -3
+ Partials 909 903 -6
|
arnabmitra
previously approved these changes
Jan 27, 2022
Co-authored-by: Daniel Wedul <[email protected]>
arnabmitra
approved these changes
Jan 27, 2022
iramiller
approved these changes
Jan 27, 2022
fkneeland-figure
pushed a commit
that referenced
this pull request
Feb 22, 2022
* Add attribute length change * Updated logging * Add changelog entry * Update CHANGELOG.md Co-authored-by: Daniel Wedul <[email protected]> Co-authored-by: Daniel Wedul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-opened issue to add upgrade change to attribute's max value length and add changelog entries.
closes: #616
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes