Fix logger ignoring configuration #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that the configured values can be used as needed.
dwedul-figure
requested review from
arnabmitra,
channa-figure and
iramiller
as code owners
Codecov Report
@@ Coverage Diff @@
## main #510 +/- ##
==========================================
+ Coverage 54.68% 54.72% +0.04%
==========================================
Files 149 149
Lines 19211 19214 +3
==========================================
+ Hits 10505 10515 +10
+ Misses 7884 7876 -8
- Partials 822 823 +1
|
arnabmitra
previously approved these changes
Sep 29, 2021
# Conflicts: # CHANGELOG.md
dwedul-figure
dismissed stale reviews from arnabmitra and iramiller
via
941df0d
arnabmitra
approved these changes
Sep 30, 2021
dwedul-figure
added a commit
that referenced
this pull request
Sep 30, 2021
* Move logger creation to happen after the configs have been loaded so that the configured values can be used as needed. * Add changelog line.
iramiller
added a commit
that referenced
this pull request
Sep 30, 2021
* Add 1.7.2 change log * Update dependencies (#513) * Update dependencies * update unsigned tx method signature * Fix logger ignoring configuration (#510) * Move logger creation to happen after the configs have been loaded so that the configured values can be used as needed. * Add changelog line. Co-authored-by: Carlton Hanna <[email protected]> Co-authored-by: Daniel Wedul <[email protected]> Co-authored-by: Carlton Hanna <[email protected]> Co-authored-by: Carlton Hanna <[email protected]> Co-authored-by: egaxhaj-figure <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…that the configured values can be used as needed.
Description
The logger was being created before the configuration was being loaded. That made it so that the configured
log_levelandlog_formatwere being ignored and only flags and defaults were used for them.This fix moves the logger creation and setting until later, once the configs have been loaded.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes