Attribute module simulation support #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iramiller
force-pushed
the
25-attribute-simulation-support
branch
from
7d79e5f
to
78f2fda
Compare
Codecov Report
@@ Coverage Diff @@
## main #348 +/- ##
==========================================
+ Coverage 50.72% 51.06% +0.33%
==========================================
Files 127 129 +2
Lines 11445 11574 +129
==========================================
+ Hits 5806 5910 +104
- Misses 5068 5087 +19
- Partials 571 577 +6
|
iramiller
requested review from
arnabmitra,
channa-figure and
dwedul-figure
as code owners
This fixes an issue uncovered during simulation testing where deleting an attribute would fail when the name was no longer present for ownership verification.
fix tests for orphan attributes
|
Further testing has exposed bugs (can't attribute a root name, and broken tests for deleting orphan attributes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds simulation support to the attribute module
closes: #25
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes