Wire in our own swagger docs #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e get our own file.
…registered with statik so that when the swagger-ui is activated, it finds our own swagger stuff rather than the Cosmos SDK swagger stuff.
…ous that we were getting our own stuff now.
…t call into the update-swagger-docs command. In order to correctly update the docs, both need to be run anyway and this will hopefully prevent confusion.
…ctually available, and also swap the order around a bit so that we're formatting and linting before generating.
…e top to better reflect our usage of the file and also to indicate that PRs can be referenced now too.
iramiller
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dockerfiles to copy theclientdirectory now too (sinceapp.goimports a file from there).Makefileto remove theproto-swagger-gencommand and put that functionality completely underupdate-swagger-docs.Makefileto clean up theproto-allcommand by removing some unavailable commands and reordering the list so thatproto-formatandproto-lintcome beforeproto-gen.Makefileto output a reminder afterproto-gento also runmake update-swagger-docsonce done making proto changes (if there are any).Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes