Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typed events and metrics to the Attribute module #279

Merged
merged 6 commits into from
Apr 29, 2021

Conversation

channa-figure
Copy link
Contributor

@channa-figure channa-figure commented Apr 29, 2021

Description

Implementation of typed events and metrics for the attribute module.
closes: #86


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@channa-figure channa-figure added enhancement New feature or request attribute Attribute Module labels Apr 29, 2021
@channa-figure channa-figure added this to the v1.3.0 milestone Apr 29, 2021
@channa-figure channa-figure self-assigned this Apr 29, 2021
@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #279 (cf0782b) into main (eede82d) will decrease coverage by 0.12%.
The diff coverage is 12.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
- Coverage   50.24%   50.12%   -0.13%     
==========================================
  Files         119      122       +3     
  Lines       11025    11115      +90     
==========================================
+ Hits         5540     5571      +31     
- Misses       4938     4995      +57     
- Partials      547      549       +2     
Impacted Files Coverage Δ
x/attribute/keeper/msg_server.go 1.44% <0.00%> (-0.83%) ⬇️
x/attribute/types/events.go 0.00% <0.00%> (ø)
x/attribute/keeper/keeper.go 70.19% <60.00%> (-1.09%) ⬇️
x/attribute/handler.go 81.81% <0.00%> (ø)
x/attribute/module.go 47.05% <0.00%> (ø)

@channa-figure channa-figure marked this pull request as ready for review April 29, 2021 16:05
@channa-figure channa-figure enabled auto-merge (squash) April 29, 2021 16:05
Copy link
Contributor

@dwedul-figure dwedul-figure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@channa-figure channa-figure merged commit 0141016 into main Apr 29, 2021
@channa-figure channa-figure deleted the channa/86-attribute-typed-events-metrics branch April 29, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attribute Attribute Module enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add typed events and metrics to the Attribute module
2 participants