Replace cometbft v0.38.9 with our own fork's v0.38.10-pio-1. #2087
Conversation
WalkthroughThe recent updates involve transitioning dependencies to Provenance forks for better stability and enhancements. Specifically, the major change is shifting from Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
go.mod (1)
214-214: Action Required: Update all references to the newwasmdversion.The replacement of
github.com/CosmWasm/wasmdwithgithub.com/provenance-io/wasmd v0.52.0-pio-1in thego.modfile is not fully propagated throughout the codebase. Please update the following files to reference the new version:
x/oracle/types/tx.pb.gox/oracle/keeper/mocks_test.gox/oracle/keeper/icq.gox/oracle/keeper/query_server.gox/oracle/types/query.pb.gox/oracle/keeper/keeper.gox/ibchooks/wasm_hook.gox/ibchooks/keeper/keeper.gotestutil/contracts/wasm.gointernal/provwasm/message_encoders.gointernal/provwasm/simulation.gointernal/provwasm/stargate_whitelist.gointernal/provwasm/query_plugins.gointernal/antewrapper/tx_gas_limit_decorator_test.goapp/sim_test.goapp/pio_message_router.goapp/app.gocmd/provenanced/cmd/root_test.goEnsure all usages are compatible with
github.com/provenance-io/wasmd v0.52.0-pio-1.Analysis chain
LGTM! Verify the usage of the new
wasmdversion.The replacement of
github.com/CosmWasm/wasmdwithgithub.com/provenance-io/wasmd v0.52.0-pio-1is approved.However, ensure that all usages of
wasmdare compatible with the new version.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all usages of `wasmd` are compatible with the new version. # Test: Search for the usage of `wasmd`. Expect: Only compatible usages. rg --type go -A 5 $'wasmd'Length of output: 11399
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- go.mod (2 hunks)
Files skipped from review due to trivial changes (1)
- CHANGELOG.md
Additional comments not posted (2)
go.mod (2)
216-216: LGTM! Verify the usage of the newcometbftversion.The replacement of
github.com/cometbft/cometbftwithgithub.com/provenance-io/cometbft-pio v0.38.10-pio-1is approved.However, ensure that all usages of
cometbftare compatible with the new version.Verification successful
The replacement of
github.com/cometbft/cometbftwithgithub.com/provenance-io/cometbft-piohas been successfully completed across the codebase.All instances have been updated appropriately.
- Verified files:
x/trigger/types/trigger.gox/trigger/types/trigger_test.gox/trigger/client/cli/cli_test.gox/trigger/keeper/keeper_test.gox/trigger/module/module.gox/quarantine/send_restriction_test.gox/quarantine/keeper/keeper_test.gox/quarantine/module/module.gox/sanction/simulation/operations_test.gox/name/module.gox/oracle/keeper/relay.gox/oracle/module/module.gox/oracle/keeper/keeper_test.gox/oracle/keeper/relay_test.gox/oracle/keeper/icq.gox/quarantine/client/cli/util.gox/quarantine/client/testutil/query_test.gox/quarantine/client/testutil/tx_test.gox/marker/types/key.gox/marker/types/send_restrictions_test.gox/ibcratelimit/module/module.gox/ibchooks/module.gox/metadata/module.gox/msgfees/keeper/params_test.gox/msgfees/keeper/keeper_test.gox/ibchooks/keeper/msg_server_test.gox/metadata/client/cli/cli_test.gox/ibchooks/client/cli/cli_test.gox/marker/client/cli/cli_test.gox/hold/keeper/grpc_query.gointernal/handlers/aggregate_events.gointernal/handlers/msg_service_router_test.gointernal/handlers/bank_send_restriction_test.gointernal/handlers/aggregate_events_test.gocmd/provenanced/config/manager.gocmd/provenanced/cmd/init.gocmd/provenanced/cmd/root.gocmd/provenanced/cmd/pre_upgrade_test.gocmd/provenanced/config/manager_test.gocmd/provenanced/cmd/testnet.goapp/app_test.goapp/app.goapp/sim_bench_test.goapp/export.goapp/test_helpers.goapp/upgrades_test.goapp/sim_test.goapp/group_test.gothird_party/proto/tendermint/version/types.protothird_party/proto/cosmwasm/wasm/v1/types.protothird_party/proto/cosmwasm/wasm/v1/query.protothird_party/proto/tendermint/consensus/types.protothird_party/proto/tendermint/consensus/wal.protothird_party/proto/tendermint/privval/types.protothird_party/proto/tendermint/statesync/types.protothird_party/proto/tendermint/types/evidence.protothird_party/proto/tendermint/state/types.protothird_party/proto/tendermint/types/validator.protothird_party/proto/tendermint/store/types.protothird_party/proto/tendermint/types/types.protothird_party/proto/tendermint/rpc/grpc/types.protothird_party/proto/tendermint/types/canonical.protothird_party/proto/tendermint/types/params.protothird_party/proto/ibc/lightclients/tendermint/v1/tendermint.protothird_party/proto/tendermint/types/events.protothird_party/proto/tendermint/types/block.protothird_party/proto/tendermint/p2p/conn.protothird_party/proto/tendermint/p2p/types.protothird_party/proto/tendermint/mempool/types.protothird_party/proto/tendermint/crypto/keys.protothird_party/proto/tendermint/blocksync/types.protothird_party/proto/tendermint/abci/types.protothird_party/proto/tendermint/libs/bits/types.protothird_party/proto/tendermint/p2p/pex.protothird_party/proto/tendermint/crypto/proof.protoScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all usages of `cometbft` are compatible with the new version. # Test: Search for the usage of `cometbft`. Expect: Only compatible usages. rg --type go -A 5 $'cometbft'Length of output: 57811
Script:
#!/bin/bash # Description: Replace all occurrences of `github.com/cometbft/cometbft` with `github.com/provenance-io/cometbft-pio` # Find all Go files and replace occurrences. rg --files-with-matches 'github.com/cometbft/cometbft' | xargs sed -i 's|github.com/cometbft/cometbft|github.com/provenance-io/cometbft-pio|g' # Verify the replacement rg 'github.com/provenance-io/cometbft-pio'Length of output: 16626
217-217: LGTM! Verify the usage of the newcosmos-sdkversion.The replacement of
github.com/cosmos/cosmos-sdkwithgithub.com/provenance-io/cosmos-sdk v0.50.7-pio-1is approved.However, ensure that all usages of
cosmos-sdkare compatible with the new version.
* Replace cometbft v0.38.9 with our own fork's v0.38.10-pio-1. * Add changelog entry.
Description
Bump cometbft to
v0.38.10-pio-1(fromv0.38.9).This has the fixed block-results query. We're using our own fork for this because cometbft hasn't tagged a version with the fix yet, and we need it now.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passesSummary by CodeRabbit
cometbftupdated to v0.38.10-pio-1wasmdreplaced with v0.52.0-pio-1cosmos-sdkreplaced with v0.50.7-pio-1go-buffer-pool.