Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the SDK to v0.50.7-pio-1 (from v0.50.5-pio-3). #2026

Merged
merged 14 commits into from
Jun 12, 2024
Merged

Bump the SDK to v0.50.7-pio-1 (from v0.50.5-pio-3). #2026

merged 14 commits into from
Jun 12, 2024

Conversation

SpicyLemon
Copy link
Contributor

@SpicyLemon SpicyLemon commented Jun 11, 2024 •
edited
Loading

Description

This PR:

  • Bumps the cosmos-sdk library to v0.50.7-pio-1 (from v0.50.5-pio-3).
  • Updates the upgrade-test script to handle this version.

Related to:

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Summary by CodeRabbit

  • New Features

    • Added support for specifying the order of send restrictions in the Module message definition.

  • Bug Fixes

    • Adjusted FeeGrantKeeper and AuthzKeeper to set the BankKeeper properly.
    • Updated configuration tests to handle mempool.max-txs parameter changes.

  • Chores

    • Updated various dependencies to their latest versions, improving stability and performance.
    • Enhanced upgrade scripts to support multiple SDK versions and adjusted command parameters accordingly.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 11, 2024 •
edited
Loading

Warning

Rate limit exceeded

@SpicyLemon has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 33 minutes and 57 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between c6ca390 and b5c27c4.

Walkthrough

The recent changes primarily involve bumping versions of various dependencies and updating configurations. Notable updates include enhancements in cosmossdk.io modules, adjustments in app/app.go for FeeGrantKeeper and AuthzKeeper, configuration changes in cmd/provenanced/cmd/config_test.go, and script modifications in upgrade-test.sh. These updates aim to improve compatibility, functionality, and performance across the project.

Changes

Files/Paths Change Summary
CHANGELOG.md Updated dependency versions for multiple modules.
app/app.go Added .SetBankKeeper(app.BankKeeper) method calls for FeeGrantKeeper and AuthzKeeper.
cmd/provenanced/cmd/config_test.go Changed mempool.max-txs configuration parameter from 5000 to -1.
go.mod Bumped versions for various dependencies including cosmossdk.io modules and other libraries.
scripts/upgrade-test.sh Enhanced support for different SDK versions, adjusted command parameters, and updated workflows.
third_party/proto/.../module.proto Added repeated string restrictions_order field to Module message.

Poem

In the code, new versions bloom,
Dependencies rise, dispelling gloom,
Keepers set with care,
Configs altered with flair,
Scripts evolve, a brighter room.
Through the lines, progress looms,
A project renewed, in full bloom. 🌸

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@SpicyLemon SpicyLemon marked this pull request as ready for review June 11, 2024 22:26
@SpicyLemon SpicyLemon requested a review from a team as a code owner June 11, 2024 22:26
iramiller
iramiller previously approved these changes Jun 11, 2024
View reviewed changes
coderabbitai[bot]
coderabbitai bot reviewed Jun 11, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range and nitpick comments (6)
CHANGELOG.md (6)

Line range hint 127-151: Consider using a consistent list marker style in Markdown.

- - Bump `cosmossdk.io/x/upgrade` from 0.1.0 to 0.1.3 ([#1913](https://github.com/provenance-io/provenance/pull/1913), [#2026](https://github.com/provenance-io/provenance/pull/2026))
+ * Bump `cosmossdk.io/x/upgrade` from 0.1.0 to 0.1.3 ([#1913](https://github.com/provenance-io/provenance/pull/1913), [#2026](https://github.com/provenance-io/provenance/pull/2026))

Please replace all instances of - with * for list items to maintain consistency.

Also applies to: 221-251, 281-283, 360-382, 738-738, 746-746, 791-791, 799-799, 845-845

Tools
Markdownlint

130-130: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

131-131: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

132-132: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

133-133: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

134-134: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

135-135: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

136-136: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

Line range hint 1241-1241: Avoid using multiple spaces after the hash in ATX style headings.

- ##  Features
+ ## Features
Tools
Markdownlint

130-130: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

131-131: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

132-132: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

133-133: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

134-134: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

135-135: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

136-136: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

Line range hint 781-781: Ensure headings are unique to maintain clarity and navigability.

- ### Bug Fixes
+ ### Bug Fixes in Module X

Consider renaming the headings to reflect the specific sections they describe.

Also applies to: 822-822, 1116-1116

Tools
Markdownlint

130-130: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

131-131: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

132-132: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

133-133: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

134-134: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

135-135: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

136-136: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

Line range hint 256-256: Avoid using bare URLs in Markdown files.

- https://github.com/provenance-io/provenance/issues/123
+ [Issue 123](https://github.com/provenance-io/provenance/issues/123)

Replace bare URLs with descriptive link text to improve readability.

Also applies to: 287-287, 386-386, 436-436, 448-448, 464-464, 535-535, 546-546, 554-554, 590-590, 615-615, 627-627, 673-673, 674-674, 675-675, 676-676, 677-677, 724-724, 765-765, 818-818, 931-931

Tools
Markdownlint

130-130: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

131-131: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

132-132: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

133-133: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

134-134: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

135-135: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

136-136: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

Line range hint 973-973: Remove spaces inside emphasis markers.

- ** This is important **
+ **This is important**
Tools
Markdownlint

130-130: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

131-131: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

132-132: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

133-133: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

134-134: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

135-135: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

136-136: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

Line range hint 369-369: Remove spaces inside code span elements.

- ` code `
+ `code`
Tools
Markdownlint

130-130: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

131-131: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

132-132: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

133-133: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

134-134: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

135-135: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

136-136: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ba03fc5 and 74598eb.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (6)
  • CHANGELOG.md (2 hunks)
  • app/app.go (2 hunks)
  • cmd/provenanced/cmd/config_test.go (4 hunks)
  • go.mod (7 hunks)
  • scripts/upgrade-test.sh (1 hunks)
  • third_party/proto/cosmos/bank/module/v1/module.proto (1 hunks)
Additional context used
Markdownlint
CHANGELOG.md

127-127: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

128-128: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

129-129: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

130-130: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

131-131: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

132-132: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

133-133: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

134-134: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

135-135: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

136-136: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

137-137: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

138-138: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

139-139: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

140-140: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

141-141: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

142-142: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

143-143: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

144-144: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

145-145: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

146-146: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

147-147: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

148-148: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

149-149: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

150-150: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

151-151: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

221-221: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

222-222: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

223-223: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

224-224: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

225-225: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

226-226: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

227-227: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

228-228: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

229-229: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

230-230: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

231-231: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

232-232: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

233-233: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

239-239: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

240-240: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

241-241: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

242-242: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

243-243: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

244-244: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

245-245: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

246-246: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

247-247: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

248-248: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

249-249: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

250-250: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

251-251: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

252-252: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

281-281: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

282-282: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

283-283: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

360-360: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

361-361: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

362-362: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

363-363: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

364-364: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

365-365: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

366-366: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

367-367: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

368-368: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

369-369: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

370-370: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

371-371: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

372-372: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

373-373: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

374-374: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

375-375: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

376-376: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

377-377: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

378-378: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

379-379: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

380-380: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

381-381: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

382-382: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

738-738: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

746-746: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

791-791: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

799-799: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

845-845: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines

1246-1246: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines

1263-1263: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines

1315-1315: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines

1419-1419: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines

1241-1241: null (MD019, no-multiple-space-atx)
Multiple spaces after hash on atx style heading

781-781: null (MD024, no-duplicate-heading)
Multiple headings with the same content

822-822: null (MD024, no-duplicate-heading)
Multiple headings with the same content

1116-1116: null (MD024, no-duplicate-heading)
Multiple headings with the same content

256-256: null (MD034, no-bare-urls)
Bare URL used

287-287: null (MD034, no-bare-urls)
Bare URL used

386-386: null (MD034, no-bare-urls)
Bare URL used

436-436: null (MD034, no-bare-urls)
Bare URL used

448-448: null (MD034, no-bare-urls)
Bare URL used

464-464: null (MD034, no-bare-urls)
Bare URL used

535-535: null (MD034, no-bare-urls)
Bare URL used

546-546: null (MD034, no-bare-urls)
Bare URL used

554-554: null (MD034, no-bare-urls)
Bare URL used

590-590: null (MD034, no-bare-urls)
Bare URL used

615-615: null (MD034, no-bare-urls)
Bare URL used

627-627: null (MD034, no-bare-urls)
Bare URL used

673-673: null (MD034, no-bare-urls)
Bare URL used

674-674: null (MD034, no-bare-urls)
Bare URL used

675-675: null (MD034, no-bare-urls)
Bare URL used

676-676: null (MD034, no-bare-urls)
Bare URL used

677-677: null (MD034, no-bare-urls)
Bare URL used

724-724: null (MD034, no-bare-urls)
Bare URL used

765-765: null (MD034, no-bare-urls)
Bare URL used

818-818: null (MD034, no-bare-urls)
Bare URL used

931-931: null (MD034, no-bare-urls)
Bare URL used

973-973: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

973-973: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

369-369: null (MD038, no-space-in-code)
Spaces inside code span elements

Additional comments not posted (8)
third_party/proto/cosmos/bank/module/v1/module.proto (1)

21-25: Field restrictions_order added to Module message.

go.mod (1)

13-17: Updated versions of multiple dependencies.

Also applies to: 24-24, 43-43, 72-72, 82-82, 146-146, 160-160, 163-166, 215-215

cmd/provenanced/cmd/config_test.go (4)

295-295: Adjustment of mempool.max-txs to -1 to disable transaction limits in the mempool.

This change aligns with the PR's objective to adjust configuration settings. Ensure that this setting is well-documented to avoid confusion about the meaning of -1 in this context.

467-467: The test output has been updated to reflect the new default value of mempool.max-txs.

Good job on updating the test expectations to match the new configuration. This ensures that the tests remain valid and effective.

512-512: The configuration retrieval for mempool now correctly reflects the new default setting.

It's crucial that the configuration retrieval logic is updated to match the new settings, ensuring consistency across the application.

690-690: The change detection for mempool.max-txs correctly identifies it as unchanged from the default, which is now -1.

This update is essential for the changed command to accurately reflect the current state of the configuration against the defaults.

app/app.go (2)

480-480: Integration of BankKeeper with FeeGrantKeeper enhances functionality.

Consider adding a comment explaining why this integration is necessary for maintainability and clarity.

508-508: Integration of BankKeeper with AuthzKeeper enhances functionality.

Consider adding a comment explaining why this integration is necessary for maintainability and clarity.

scripts/upgrade-test.sh Show resolved Hide resolved
@SpicyLemon SpicyLemon enabled auto-merge (squash) June 11, 2024 22:42
iramiller
iramiller previously approved these changes Jun 11, 2024
View reviewed changes
coderabbitai[bot]
coderabbitai bot reviewed Jun 11, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (6)
CHANGELOG.md (6)

Line range hint 128-152: Consider using asterisks (*) for unordered lists to maintain consistency across the document.

- - Bump `github.com/cosmos/ibc-go/v8` from 8.0.0 to 8.2.1 ([#1910](https://github.com/provenance-io/provenance/pull/1910), [#1956](https://github.com/provenance-io/provenance/pull/1956))
+ * Bump `github.com/cosmos/ibc-go/v8` from 8.0.0 to 8.2.1 ([#1910](https://github.com/provenance-io/provenance/pull/1910), [#1956](https://github.com/provenance-io/provenance/pull/1956))

Also applies to: 222-252, 282-284, 361-383, 739-739, 747-747, 792-792, 800-800, 846-846, 1247-1247, 1264-1264, 1316-1316, 1420-1420

Tools
Markdownlint

131-131: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

132-132: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

133-133: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

134-134: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

135-135: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

136-136: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

137-137: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

Line range hint 1242-1242: Ensure there is only one space after the hash in ATX style headings.

- ##  [v1.1.1](https://github.com/provenance-io/provenance/releases/tag/v1.1.1) - 2021-03-11
+ ## [v1.1.1](https://github.com/provenance-io/provenance/releases/tag/v1.1.1) - 2021-03-11

Line range hint 782-782: Avoid using duplicate headings to improve document structure and navigation.

- ### Bug Fixes
+ ### Bug Fixes for Version X.Y.Z

Also applies to: 823-823, 1117-1117

Line range hint 257-257: Consider using Markdown links instead of bare URLs to improve readability and document aesthetics.

- https://github.com/provenance-io/provenance/issues/123
+ [Issue 123](https://github.com/provenance-io/provenance/issues/123)

Also applies to: 288-288, 387-387, 437-437, 449-449, 465-465, 536-536, 547-547, 555-555, 591-591, 616-616, 628-628, 674-674, 675-675, 676-676, 677-677, 678-678, 725-725, 766-766, 819-819, 932-932

Line range hint 974-974: Remove spaces inside emphasis markers to correct Markdown formatting.

- ** This is a test **
+ **This is a test**

Line range hint 370-370: Remove spaces inside code span elements to correct Markdown formatting.

- ` code `
+ `code`
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 74598eb and c6ca390.

Files selected for processing (1)
  • CHANGELOG.md (3 hunks)
Additional context used
Markdownlint
CHANGELOG.md

128-128: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

129-129: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

130-130: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

131-131: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

132-132: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

133-133: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

134-134: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

135-135: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

136-136: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

137-137: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

138-138: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

139-139: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

140-140: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

141-141: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

142-142: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

143-143: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

144-144: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

145-145: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

146-146: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

147-147: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

148-148: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

149-149: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

150-150: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

151-151: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

152-152: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

222-222: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

223-223: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

224-224: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

225-225: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

226-226: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

227-227: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

228-228: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

229-229: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

230-230: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

231-231: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

232-232: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

233-233: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

239-239: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

240-240: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

241-241: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

242-242: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

243-243: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

244-244: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

245-245: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

246-246: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

247-247: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

248-248: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

249-249: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

250-250: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

251-251: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

252-252: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

253-253: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

282-282: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

283-283: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

284-284: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

361-361: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

362-362: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

363-363: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

364-364: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

365-365: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

366-366: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

367-367: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

368-368: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

369-369: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

370-370: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

371-371: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

372-372: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

373-373: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

374-374: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

375-375: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

376-376: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

377-377: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

378-378: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

379-379: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

380-380: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

381-381: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

382-382: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

383-383: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

739-739: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

747-747: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

792-792: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

800-800: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

846-846: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines

1247-1247: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines

1264-1264: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines

1316-1316: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines

1420-1420: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines

1242-1242: null (MD019, no-multiple-space-atx)
Multiple spaces after hash on atx style heading

782-782: null (MD024, no-duplicate-heading)
Multiple headings with the same content

823-823: null (MD024, no-duplicate-heading)
Multiple headings with the same content

1117-1117: null (MD024, no-duplicate-heading)
Multiple headings with the same content

257-257: null (MD034, no-bare-urls)
Bare URL used

288-288: null (MD034, no-bare-urls)
Bare URL used

387-387: null (MD034, no-bare-urls)
Bare URL used

437-437: null (MD034, no-bare-urls)
Bare URL used

449-449: null (MD034, no-bare-urls)
Bare URL used

465-465: null (MD034, no-bare-urls)
Bare URL used

536-536: null (MD034, no-bare-urls)
Bare URL used

547-547: null (MD034, no-bare-urls)
Bare URL used

555-555: null (MD034, no-bare-urls)
Bare URL used

591-591: null (MD034, no-bare-urls)
Bare URL used

616-616: null (MD034, no-bare-urls)
Bare URL used

628-628: null (MD034, no-bare-urls)
Bare URL used

674-674: null (MD034, no-bare-urls)
Bare URL used

675-675: null (MD034, no-bare-urls)
Bare URL used

676-676: null (MD034, no-bare-urls)
Bare URL used

677-677: null (MD034, no-bare-urls)
Bare URL used

678-678: null (MD034, no-bare-urls)
Bare URL used

725-725: null (MD034, no-bare-urls)
Bare URL used

766-766: null (MD034, no-bare-urls)
Bare URL used

819-819: null (MD034, no-bare-urls)
Bare URL used

932-932: null (MD034, no-bare-urls)
Bare URL used

974-974: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

974-974: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

370-370: null (MD038, no-space-in-code)
Spaces inside code span elements

@SpicyLemon SpicyLemon merged commit 420ab19 into main Jun 12, 2024
32 checks passed
@SpicyLemon SpicyLemon deleted the dwedul/1760-bump-sdk-to-50.7 branch June 12, 2024 20:41
This was referenced Oct 10, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@Taztingo Taztingo Taztingo approved these changes

@nullpointer0x00 nullpointer0x00 nullpointer0x00 approved these changes

@iramiller iramiller iramiller left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SpicyLemon @iramiller @nullpointer0x00 @Taztingo