Change default iavl-disable-fastnode and indexer values. #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… That's what the config file says to use.
…ex.indexer to 'null'.
Taztingo
approved these changes
Jan 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1807 +/- ##
==========================================
+ Coverage 73.96% 73.97% +0.01%
==========================================
Files 315 315
Lines 44762 44764 +2
==========================================
+ Hits 33108 33114 +6
+ Misses 10274 10269 -5
- Partials 1380 1381 +1
|
iramiller
approved these changes
Jan 11, 2024
SpicyLemon
added a commit
that referenced
this pull request
Jan 11, 2024
* Don't issue a warning on start when the indexer is the string 'null'. That's what the config file says to use. * Set the default iavl-disable-fastnode to false and the default tx_index.indexer to 'null'. * Add Changelog entry. * Add unit test for no wait for an indexer of 'null'.
8 tasks
SpicyLemon
added a commit
that referenced
this pull request
Jan 11, 2024
* Don't issue a warning on start when the indexer is the string 'null'. That's what the config file says to use. * Set the default iavl-disable-fastnode to false and the default tx_index.indexer to 'null'. * Add Changelog entry. * Add unit test for no wait for an indexer of 'null'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the default
iavl-disable-fastnodevalue tofalseand the defaulttx_index.indexervalue to"null". It also allows thetx_index.indexervalue to be either""or"null"without issuing a warning.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes