Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create pre-upgrade command. Fix minimum-gas-prices repacking unset. #1594

Merged
merged 33 commits into from
Jun 20, 2023
Merged

Create pre-upgrade command. Fix minimum-gas-prices repacking unset. #1594

merged 33 commits into from
Jun 20, 2023

Commits on Jun 13, 2023

  1. Create a new pre_upgrade command that updates the config files. Make … 

    …it also set the commit timeout if needed. Make it so that stuff that uses the global viper also gets everything that's needed.
    @SpicyLemon
    SpicyLemon committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    b8f5741 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Force the timeout commit to 5s in all cases. Add some comments and in… 

    …fo about what cosmovisor expects.
    @SpicyLemon
    SpicyLemon committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    4863fb6 View commit details
    Browse the repository at this point in the history

  2. Undo the PersistentPreRunE extraction change since I ended up not nee… 

    …ding it for the unit tests.
    @SpicyLemon
    SpicyLemon committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    245f65e View commit details
    Browse the repository at this point in the history

  3. Fix the existing LogIfError functions.

    @SpicyLemon
    SpicyLemon committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    82b946e View commit details
    Browse the repository at this point in the history

  4. Tweak errors returned from pre-upgrade to contain more context and st… 

    …ill be indicate the desired exit code.
    @SpicyLemon
    SpicyLemon committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    cea713a View commit details
    Browse the repository at this point in the history

  5. Allow creation of the root command that won't seal the app config so … 

    …we can run it multiple times, e.g. from unit tests. Also, add extra handling of ErrorCodes to main since it's sometimes a pointer and sometimes not.
    @SpicyLemon
    SpicyLemon committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    093655f View commit details
    Browse the repository at this point in the history

  6. Add unit tests on the pre-upgrade command.

    @SpicyLemon
    SpicyLemon committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    7ae0a76 View commit details
    Browse the repository at this point in the history

  7. Add a unit test for when the config can't be written.

    @SpicyLemon
    SpicyLemon committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    0b39af0 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Add newline to end of success message.

    @SpicyLemon
    SpicyLemon committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    74aea01 View commit details
    Browse the repository at this point in the history

  2. Move the global min-gas-prices setting stuff into the interceptor so … 

    …that it happens before the config files are loaded or any defaults are requested.
    @SpicyLemon
    SpicyLemon committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    8806ed1 View commit details
    Browse the repository at this point in the history

  3. For the init cmd test, don't seal the config (so other things that mi… 

    …ght need to can do so), and use a temp directory instead of the default.
    @SpicyLemon
    SpicyLemon committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    588515a View commit details
    Browse the repository at this point in the history

  4. Update some tests that started failing because the default timeout_co… 

    …mmit changed.
    @SpicyLemon
    SpicyLemon committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    8874407 View commit details
    Browse the repository at this point in the history

  5. Just pass sealConfig into the SetConfig function instead of optionall… 

    …y calling it.
    @SpicyLemon
    SpicyLemon committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    521bee0 View commit details
    Browse the repository at this point in the history

  6. For the pre-unpgrade tests, just add the home dir as a flag for the c… 

    …ommand.
    @SpicyLemon
    SpicyLemon committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    67b157b View commit details
    Browse the repository at this point in the history

  7. Add temporary changelog entries.

    @SpicyLemon
    SpicyLemon committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    522fd50 View commit details
    Browse the repository at this point in the history

  8. Remove some lines added just for debugging.

    @SpicyLemon
    SpicyLemon committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    4f0ed39 View commit details
    Browse the repository at this point in the history

  9. When starting a node with a timeout_commit of less than 4 seconds, ou… 

    …tput a message stating that it should be set to 5s.
    @SpicyLemon
    SpicyLemon committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    488cb85 View commit details
    Browse the repository at this point in the history

  10. Update the initialization script to put the timeout_commit back to 1s… 

    … so that make run cuts blocks faster.
    @SpicyLemon
    SpicyLemon committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    068a3be View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Merge branch 'main' into dwedul/1.16-pre-upgrade-cmd 

    # Conflicts:
#	CHANGELOG.md
    @SpicyLemon
    SpicyLemon committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    535835a View commit details
    Browse the repository at this point in the history

  2. Only issue low timeout_commit warning on mainnet.

    @SpicyLemon
    SpicyLemon committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    a038026 View commit details
    Browse the repository at this point in the history

  3. Replace some deprecated stuff and fix some receivers.

    @SpicyLemon
    SpicyLemon committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    bd445b6 View commit details
    Browse the repository at this point in the history

  4. During pre-upgrae Only update the configured value if it's lower than… 

    … half the default.
    @SpicyLemon
    SpicyLemon committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    d3599e0 View commit details
    Browse the repository at this point in the history

  5. Only log the warning on mainnet and only if it's less than half the d… 

    …efault.
    @SpicyLemon
    SpicyLemon committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    e7491d7 View commit details
    Browse the repository at this point in the history

  6. Add the --timeout-commit flag to the init command. If provided, use t… 

    …hat. Otherwise, if something other than mainnet or testnet, use 1s. Otherwise, use whatever was previously in their config or the default if it's brand new.
    @SpicyLemon
    SpicyLemon committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    0269846 View commit details
    Browse the repository at this point in the history

  7. Update the initialize script to provide the --timeout-commit to init … 

    …instead of setting it using the config command at the end.
    @SpicyLemon
    SpicyLemon committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    925a4b1 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into dwedul/1.16-pre-upgrade-cmd 

    # Conflicts:
#	CHANGELOG.md
    @SpicyLemon
    SpicyLemon committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    137e9c7 View commit details
    Browse the repository at this point in the history

  9. Upper-case the first letter of all commmand and flag usage strings. F… 

    …ix the debug pubkey-raw command that had a conflicting shorthand flag being added.
    @SpicyLemon
    SpicyLemon committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    da2044a View commit details
    Browse the repository at this point in the history

  10. Fix the --help flag capitalization.

    @SpicyLemon
    SpicyLemon committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    1b76d14 View commit details
    Browse the repository at this point in the history

  11. Undo the usage capitalization stuff. That's a bit too off-topic for t… 

    …his PR.
    @SpicyLemon
    SpicyLemon committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    b3021cb View commit details
    Browse the repository at this point in the history

  12. In the pre-upgrade command only change the timeout_commit for mainnet… 

    … nodes.
    @SpicyLemon
    SpicyLemon committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    c615a61 View commit details
    Browse the repository at this point in the history

  13. Get rid of the global ChainID variable (in cmd/root.go) since it wasn… 

    …'t used before this PR and it wasn't really worthwhile even after setting it due to the package it's in.
    @SpicyLemon
    SpicyLemon committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    efcc9a7 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'main' into dwedul/1.16-pre-upgrade-cmd

    @SpicyLemon
    SpicyLemon authored Jun 16, 2023
    Configuration menu
    Copy the full SHA
    4b8c798 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Merge branch 'main' into dwedul/1.16-pre-upgrade-cmd

    @SpicyLemon
    SpicyLemon authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    287956d View commit details
    Browse the repository at this point in the history