Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow some messages and mark v1.15.2. #1576

Merged
merged 3 commits into from
Jun 8, 2023
Merged

Disallow some messages and mark v1.15.2. #1576

merged 3 commits into from
Jun 8, 2023

Conversation

SpicyLemon
Copy link
Contributor

@SpicyLemon SpicyLemon commented Jun 8, 2023 •
edited
Loading

Description

Disallow some messages due to barberry.
Mark v1.15.2 in the changelog.

This PR is only applied to release/v1.15.x as it won't be needed in main. main will get an updated SDK version with a better fix.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@SpicyLemon SpicyLemon requested a review from a team as a code owner June 8, 2023 17:32
@SpicyLemon SpicyLemon changed the title Disallow some messages Disallow some messages and mark v1.15.2. Jun 8, 2023
@nullpointer0x00 nullpointer0x00 self-requested a review June 8, 2023 17:46
iramiller
iramiller approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@iramiller iramiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a good interim solution until the circuit breaker is available

Taztingo
Taztingo approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@Taztingo Taztingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iramiller iramiller merged commit 7c9a616 into release/v1.15.x Jun 8, 2023
@iramiller iramiller deleted the dwedul/v1.15-no-per-vest branch June 8, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taztingo Taztingo Taztingo approved these changes

@nullpointer0x00 nullpointer0x00 nullpointer0x00 approved these changes

@iramiller iramiller iramiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SpicyLemon @iramiller @nullpointer0x00 @Taztingo