Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow name owner to execute msg modify name #1537

Conversation

nullpointer0x00
Copy link
Contributor

@nullpointer0x00 nullpointer0x00 commented May 8, 2023

Description

closes: #1536


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #1537 (e7ee050) into main (7916a9e) will increase coverage by 0.01%.
The diff coverage is 61.53%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1537      +/-   ##
==========================================
+ Coverage   61.48%   61.50%   +0.01%     
==========================================
  Files         197      197              
  Lines       25269    25319      +50     
==========================================
+ Hits        15537    15572      +35     
- Misses       8636     8651      +15     
  Partials     1096     1096              
Impacted Files Coverage Δ
x/name/keeper/msg_server.go 38.12% <0.00%> (ø)
x/name/client/cli/tx.go 65.03% <48.78%> (-2.69%) ⬇️
x/name/simulation/operations.go 80.98% <82.35%> (+0.43%) ⬆️

@nullpointer0x00 nullpointer0x00 self-assigned this May 8, 2023
@nullpointer0x00 nullpointer0x00 added the name Name Module label May 8, 2023
@nullpointer0x00 nullpointer0x00 added this to the v1.16.0 milestone May 8, 2023
@nullpointer0x00 nullpointer0x00 marked this pull request as ready for review May 9, 2023 18:30
@nullpointer0x00 nullpointer0x00 requested a review from a team as a code owner May 9, 2023 18:30
@nullpointer0x00 nullpointer0x00 enabled auto-merge (squash) May 9, 2023 19:19
Copy link
Contributor

@Taztingo Taztingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@iramiller iramiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being able to leverage the same methods for gov proposals and modifications is a very nice simplification.

@nullpointer0x00 nullpointer0x00 merged commit ac63812 into main May 10, 2023
@nullpointer0x00 nullpointer0x00 deleted the nullpointer0x00/1536-allow-name-owner-to-execute-MsgModifyName branch May 10, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
name Name Module
Projects
Development

Successfully merging this pull request may close these issues.

Allow name owner to execute MsgModifyName
3 participants