Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Cosmos-SDK to v0.46.6-pio-3 (from v0.46.6-pio-2). #1274

Merged
merged 3 commits into from
Dec 21, 2022

Conversation

SpicyLemon
Copy link
Contributor

@SpicyLemon SpicyLemon commented Dec 20, 2022

Description

Bump Cosmos-SDK to v0.46.6-pio-3 (from v0.46.6-pio-2).

This is only needed in release/v1.13.x. The main branch uses an SDK version that already includes these changes.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@SpicyLemon SpicyLemon requested a review from a team as a code owner December 20, 2022 20:46
derekadams
derekadams previously approved these changes Dec 20, 2022
@arnabmitra
Copy link
Contributor

arnabmitra commented Dec 20, 2022

none of the test's pass because of the go.sum errors.. weird github thing?

Error: cmd/provenanced/cmd/root.go:36:2: missing go.sum entry for module providing package github.com/cosmos/cosmos-sdk/client/rpc (imported by github.com/provenance-io/provenance/cmd/provenanced/cmd); to add:
	go get github.com/provenance-io/provenance/cmd/provenanced/cmd
Error: cmd/provenanced/cmd/testnet.go:25:2: missing go.sum entry for module providing package github.com/cosmos/cosmos-sdk/crypto/hd (imported by github.com/provenance-io/provenance/cmd/provenanced/cmd); to add:
	go get github.com/provenance-io/provenance/cmd/provenanced/cmd
Error: cmd/provenanced/cmd/root.go:15:2: missing go.sum entry for module providing package github.com/cosmos/cosmos-sdk/snapshots (imported by github.com/provenance-io/provenance/cmd/provenanced/cmd); to add:
	go get github.com/provenance-io/provenance/cmd/provenanced/cmd
Error: cmd/provenanced/cmd/testnet.go:30:2: missing go.sum entry for module providing package github.com/cosmos/cosmos-sdk/testutil (imported by github.com/provenance-io/provenance/cmd/provenanced/cmd); to add:
	go get github.com/provenance-io/provenance/cmd/provenanced/cmd
Error: cmd/provenanced/cmd/simulate.go:9:2: missing go.sum entry for module providing package github.com/cosmos/cosmos-sdk/x/auth/client (imported by github.com/provenance-io/provenance/cmd/provenanced/cmd); to add:
	go get github.com/provenance-io/provenance/cmd/provenanced/cmd
Error: cmd/provenanced/cmd/root.go:41:2: missing go.sum entry for module providing package github.com/cosmos/cosmos-sdk/x/auth/client/cli (imported by github.com/provenance-io/provenance/cmd/provenanced/cmd); to add:
	go get github.com/provenance-io/provenance/cmd/provenanced/cmd
Error: cmd/provenanced/cmd/root.go:45:2: missing go.sum entry for module providing package github.com/cosmos/cosmos-sdk/x/genutil/client/cli (imported by github.com/provenance-io/provenance/cmd/provenanced/cmd); to add:
	go get github.com/provenance-io/provenance/cmd/provenanced/cmd
Error: testutil/network.go:14:2: missing go.sum entry for module providing package github.com/cosmos/cosmos-sdk/pruning/types (imported by github.com/provenance-io/provenance/testutil); to add:
	go get github.com/provenance-io/provenance/testutil
Error: testutil/network.go:17:2: missing go.sum entry for module providing package github.com/cosmos/cosmos-sdk/testutil/network (imported by github.com/provenance-io/provenance/testutil); to add:
	go get github.com/provenance-io/provenance/testutil
Error: Process completed with exit code 123.

@SpicyLemon
Copy link
Contributor Author

SpicyLemon commented Dec 20, 2022

Oops. Yeah. Forgot to go mod tidy so go.sum wasn't right. Should be fixed now.

Right before pushing, I had the replace line pointing to a local version of the SDK. After that got tagged, I updated go.mod but forgot to go mod tidy.

@SpicyLemon SpicyLemon merged commit 913df38 into release/v1.13.x Dec 21, 2022
@SpicyLemon SpicyLemon deleted the dwedul/1.13.1-in-place-fix branch December 21, 2022 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants