-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dockerfile for arm64. #1261
Conversation
@Taztingo is there a way to re us/combine to this https://github.com/provenance-io/provenance/blob/9c4dd0f1c3169d198606b73747588b41f02836c2/networks/local/blockchain-local/Dockerfile#L89-L88 ..i do think your PR is nice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ..would def be helpful to build this directly on a M1, rather than rely on a build machine
@arnabmitra The two sections in that other Dockerfile can definitely be combined to be similar to this. It was originally separated because libwasmvm_aarch64.so didn't exist and we had to manually build it. You are correct that there isn't too much of a difference between this Dockerfile and the other one mentioned. It looks like this one is mainly used to quickly query/transact an already existing blockchain. The other one interacts with entrypoint.sh and starts a blockchain. Maybe we can make reuse the one you pointed out and add configurable params. |
probably not worth holding up this PR though..this looks like a good fix to have |
Description
Added support for arm64 in provenance-io/blockchain docker image.
closes: #1260
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes