Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dockerfile for arm64. #1261

Merged
merged 4 commits into from
Dec 14, 2022

Conversation

Taztingo
Copy link
Contributor

Description

Added support for arm64 in provenance-io/blockchain docker image.

closes: #1260


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@Taztingo Taztingo requested a review from a team as a code owner December 13, 2022 18:41
@arnabmitra
Copy link
Contributor

@arnabmitra arnabmitra self-requested a review December 13, 2022 20:08
Copy link
Contributor

@arnabmitra arnabmitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ..would def be helpful to build this directly on a M1, rather than rely on a build machine

@Taztingo
Copy link
Contributor Author

@arnabmitra The two sections in that other Dockerfile can definitely be combined to be similar to this. It was originally separated because libwasmvm_aarch64.so didn't exist and we had to manually build it.

You are correct that there isn't too much of a difference between this Dockerfile and the other one mentioned. It looks like this one is mainly used to quickly query/transact an already existing blockchain. The other one interacts with entrypoint.sh and starts a blockchain. Maybe we can make reuse the one you pointed out and add configurable params.

@arnabmitra
Copy link
Contributor

@arnabmitra The two sections in that other Dockerfile can definitely be combined to be similar to this. It was originally separated because libwasmvm_aarch64.so didn't exist and we had to manually build it.

You are correct that there isn't too much of a difference between this Dockerfile and the other one mentioned. It looks like this one is mainly used to quickly query/transact an already existing blockchain. The other one interacts with entrypoint.sh and starts a blockchain. Maybe we can make reuse the one you pointed out and add configurable params.

probably not worth holding up this PR though..this looks like a good fix to have

Makefile Show resolved Hide resolved
@Taztingo Taztingo merged commit b6acc14 into main Dec 14, 2022
@Taztingo Taztingo deleted the taztingo/1260-update-provenance-docker-image branch December 14, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The provenance-io/blockchain cannot be ran with arm64
3 participants