Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the 1.13.0-rc2 date #1185

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Fix the 1.13.0-rc2 date #1185

merged 1 commit into from
Oct 21, 2022

Conversation

SpicyLemon
Copy link
Contributor

Description

Fixes the date in the 1.13.0-rc2 headers.

I made this change locally and forgot to push it up before merging #1184.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@SpicyLemon SpicyLemon requested a review from a team as a code owner October 21, 2022 20:19
@SpicyLemon SpicyLemon merged commit e9ace44 into release/v1.13.x Oct 21, 2022
@SpicyLemon SpicyLemon deleted the dwedul/fix-1.13.0-rc2-date branch October 21, 2022 20:27
SpicyLemon added a commit that referenced this pull request Nov 23, 2022
@SpicyLemon @kwtalley
@nullpointer0x00 @arnabmitra @craigberry1 @dependabot @Taztingo @egaxhaj
v1.13.0-rc5 back to main. (#1241)
747fd22 
* Update header for v1.13.0 release in changelog (#1121)

* Update wasmd to 0.28 with 0.46 sdk version from notional-labs (#1015) (#1122) (#1126)

* update wasmd to 0.28 with 0.46 sdk version from notional-labs (#1015)

* add comment to indicate why cosmwasm_1_1 cap added

Co-authored-by: Derek Adams <[email protected]>

Co-authored-by: kwt <[email protected]>

* Add release changelog for v1.13.0-rc1 (#1128)

* Bump wasmd to v0.29.0-pio-1 (#1148) (#1162)

* Bump wasmd to our v0.29.0-pio-1 (from v0.28.0-0.46sdk-notional).

* Update changelog.

* Backport 1.13: Restricted Marker Transfer IBC (#1167)

* Restricted marker transfer over ibc (#1158)

* initial setup of the ibc transfer

* Update proto to reuse ibc transfer

* remove telemetry

* wire in ibc send

* Add tx command for ibc transfer

* add todo for tx command

* moving to ibc-testing tag.

* Fixes to cli and msg server.

* changing signer of ibc message.

* setup ibc transfer keeper before marker keeper

* refactor ibc-transfer command, setup first test for ibc-transfer cli

* add a few more cli tests

* Updating proto comments.

* Add change log entry

* add spec

* add msg test

* update ibc-go tag

Co-authored-by: arnabmitra <[email protected]>

* Re-add a changelog entry that I accidentally added in a different PR then erroneously deleted in the last conflict resolution. But since it's already in release/v1.13.x, might as well leave it.

Co-authored-by: Carlton Hanna <[email protected]>
Co-authored-by: arnabmitra <[email protected]>

* Backport 1.13: Update docs. (#1154)

* Small tweaks to the name restrictions documentation. (#1137)

* Clarify some stuff in the name concepts spec.

* Add changelog entry.

* Fix grammar.

* Dwedul/767 update release doc (#1141)

* [767]: Update the run-sims-with-all-dbs script to exit with a non-zero code if one or more of the tests did.

* Add the CONTRIBUTING.md doc to the docs updated by the update-tocs target.

* [767]: Update CONTRIBUTING.md with more accurate branch and release info

* Remove some Cosmos-Specific pieces.
* Replace some references to Cosmos-SDK.
* Update some of the PR stuff to reflect the current process.
* Refactored the "Branching Model and Release" section by splitting it
  in two and more accurately describing our branching and release
  process.
* Updated the TOC using our auto-TOC script.

* Undo the run-sims-with-all-dbs change and do that in a separate PR.

* Some tweaks after reading through it again.

* [1143]: Update the Testing section in CONTRIBUTING.md.

* Fix broken cosmos-sdk doc url (#1150)

I noticed the cosmos-sdk link on was 404'ing. I believe this is equivalent intro doc.

Co-authored-by: Craig Berry <[email protected]>

* Backport 1.13: Github actions and scripts. (#1166)

* Create check that time.Now isn't used unexpectedly. (#1133)

* Add a script that checks all the go files for improper uses of time.Now().

* Run the new no-now-lint script when doing make lint.

* Run the script in the github lint action.

* Add the lint workflow file and the no-now-lint script to the differ of the lint github workflow (so changes to those files trigger a run of that workflow).

* Add a new file that should fail the no-now lint check.

* Remove the cmd/foo.go file now that I've got an example of a failed lint job.

* Fix some typos/grammar/formatting.

* Add a go file that will fail the no now linter, but make it a bit more complex than last time to test out ignoring comments.

* Ignore 'uses' of time.Now if it's just a match in a comment.

* Indent the lines in the verbose output.

* Split the filtering out into an array of filters, each applied in its own grep invokation. This is primarily for extra insight with verbose output. But it also lets each filter be defined under a comment explaining that specific entry.

* Turn on verbose output of the no-now lint script in the github action. Will probably turn it back off, but I just want it for at least one run to double check things.

* Add a comment that explains why the no-now-lint script exists.

* Output the bad uses to stdout. During a normal run, it's the only output. With verbose, it keeps the output in sync when stdout and stderr aren't processed simultaneously.

* Remove the bad-time.go file since I have an example of it causing a failure.

* Remove the -v from the github job that runs the new no-now-lint script.

* [1125]: Remove badgerdb from the matrices in the sims jobs. (#1138)

* Define concurrency for github actions. (#1139)

* [861]: Change release.yaml to use concurrency.

* [861]: Change sims.yaml to use concurrency.

* [861]: Change test.yaml to use concurrency.

* [861]: Add concurrency to the proto workflow. Also trigger it if either of the scripts are in the PR.

* [861]: Add concurrency to the docker workflow.

* [861]: Use the same comment on all the concurrency entries.

* [861]: Add comment to the lint workflow about why concurrency isn't defined in it.

* [861]: Add concurrency to the rosetta workflow.

* [861]: Chance CodeQL workflow schedule to 9:23 PM (from 9:21 PM) and add a comment explaining it.

* [861]: Update the codeql workflow to run on all PRs, pushes to main, and version tags (used to only be PRs and pushes to main or a release branch).

* [861]: Add concurency to the codeql workflow.

* [861]: Remove the comment at the top of the codeql workflow that isn't needed anymore.

* Make run-sims-with-all-dbs.sh exit with appropriate code (#1142)

* Update the run-sims-with-all-dbs script to output whether any of the tests failed and only exit with a code of 0 if none of the tests failed.

* Add a help message to the script.

* Make the script print the actual defaults instead of just what the current env has.

* Suppress a couple git command errors when not in a git repo.

* Update devnet docker build to be current (#1098)

* update devnet dockerfile, docker-compose, and makefile to be current

* add change log entry

* update comments in Dockerfile

Co-authored-by: Carlton Hanna <[email protected]>

* Backport 1.13: Dependabot bumps. (#1155)

* Bump google.golang.org/grpc from 1.49.0 to 1.50.0 (#1140)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.49.0 to 1.50.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.49.0...v1.50.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/btcsuite/btcd from 0.22.1 to 0.22.2 (#1144)

Bumps [github.com/btcsuite/btcd](https://github.com/btcsuite/btcd) from 0.22.1 to 0.22.2.
- [Release notes](https://github.com/btcsuite/btcd/releases)
- [Changelog](https://github.com/btcsuite/btcd/blob/master/CHANGES)
- [Commits](btcsuite/btcd@v0.22.1...v0.22.2)

---
updated-dependencies:
- dependency-name: github.com/btcsuite/btcd
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump golang.org/x/text from 0.3.7 to 0.3.8 (#1146)

Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.7 to 0.3.8.
- [Release notes](https://github.com/golang/text/releases)
- [Commits](golang/text@v0.3.7...v0.3.8)

---
updated-dependencies:
- dependency-name: golang.org/x/text
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Wedul <[email protected]>

* Bump github.com/spf13/cobra from 1.5.0 to 1.6.0 (#1147)

Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.5.0 to 1.6.0.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.5.0...v1.6.0)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump google.golang.org/grpc from 1.50.0 to 1.50.1 (#1164)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.50.0 to 1.50.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.50.0...v1.50.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump technote-space/get-diff-action from 6.1.0 to 6.1.1 (#1163)

Bumps [technote-space/get-diff-action](https://github.com/technote-space/get-diff-action) from 6.1.0 to 6.1.1.
- [Release notes](https://github.com/technote-space/get-diff-action/releases)
- [Changelog](https://github.com/technote-space/get-diff-action/blob/main/.releasegarc)
- [Commits](technote-space/get-diff-action@v6.1.0...v6.1.1)

---
updated-dependencies:
- dependency-name: technote-space/get-diff-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Wedul <[email protected]>

* Bump golang.org/x/text from 0.3.8 to 0.4.0 (#1165)

Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.8 to 0.4.0.
- [Release notes](https://github.com/golang/text/releases)
- [Commits](golang/text@v0.3.8...v0.4.0)

---
updated-dependencies:
- dependency-name: golang.org/x/text
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/cosmos/cosmos-proto from 1.0.0-alpha7 to 1.0.0-alpha8 (#1156)

* Bump github.com/cosmos/cosmos-proto from 1.0.0-alpha7 to 1.0.0-alpha8

Bumps [github.com/cosmos/cosmos-proto](https://github.com/cosmos/cosmos-proto) from 1.0.0-alpha7 to 1.0.0-alpha8.
- [Release notes](https://github.com/cosmos/cosmos-proto/releases)
- [Commits](cosmos/cosmos-proto@v1.0.0-alpha7...v1.0.0-alpha8)

---
updated-dependencies:
- dependency-name: github.com/cosmos/cosmos-proto
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* make proto-update-deps

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Wedul <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Updated handler to have no enabled ica messages. (#1168) (#1170)

Co-authored-by: Matt Witkowski <[email protected]>

* Bump Cosmos-SDK to v0.46.3-pio-1 (from v0.46.2-pio-1). (#1173) (#1182)

* Use local version of the sdk and include ics replace.

* Add some changelog entries and fix the v1.13.0 entry to be reference v1.13.0-rc1.

* update the require line for cosmos-sdk to say v0.46.3 (even though we replace it below) just to make it closer to the truth.

* Enable the node query service.

* Remove my local sdk replace line and go back to the usual one. Bump Cosmos-sdk to v0.46.3-pio-1 (from v0.46.2-pio-1).

* Add links to the PR (in the changelog).

* Add a note in go.mod to update proto-update-deps.sh when updating the ics23 replace line, and hard-code that script to v0.7.0 for proofs.proto.

* make proto-update-deps

* Update swagger stuff (including third party).

* Add v1.13.0-rc2 header to the changelog and update the release changelog. (#1184)

* Copy v1.12.1 changelog entry from main.

* Add v1.13.0-rc2 section header and full commit links.

* Add the v1.13.0-rc2 section to the release changelog.

* Fix the v1.13.0-rc2 date. (#1185)

* Provide the iavl-disable-fastnode app option (#1193) (#1194)

* Make us pay attention to the iavl-disable-fastnode config setting/flag instead of always using the default.

* Add changelog entry.

* Backport 1.13: Bump Cosmos-SDK to v0.46.3-pio-2 (from v0.46.3-pio-1) (#1205)

* Bump Cosmos-SDK to v0.46.3-pio-2 (from v0.46.3-pio-1). (#1201)

* Bump Cosmos-SDK to v0.46.3-pio-2 (from v0.46.3-pio-1).

* Add changelog entry.

* Fix the link text in the changelog to indicate a PR link (for both this and the last change).

* Bump Cosmos-SDK to v0.46.3-pio-3 (from v0.46.3-pio-2). (#1206)

* Update changelog for v1.13.0-rc3 (#1197)

* Update the changelog and release changelog with v1.13.0-rc3.

* Update the dates for v1.13.0-rc3 to 2022-11-02.

* Update the release changelog with stuff added in the last merge.

* Backport 1.13: Bump Cosmos-SDK to v0.46.3-pio-4 (#1212)

* Bump sdk to v0.46.3-pio-4 and update changelog and release changelog (since it wasn't actually released yet).

* 1224 backport to v1.13.x (#1228)

* update changelog

* enable RC publishing to maven

* backport 1224

* Fix GetParams in `msgfees` modules to return ConversionFeeDenom (#1215) (#1221)

* Fix GetParams in `msgfees` modules to return ConversionFeeDenom (#1215)

* remove params from upgrade handler

Co-authored-by: Daniel Wedul <[email protected]>

* Mark v1.13.0-rc4 and backport v1.13: sdk to v0.46.4-pio-1, codeQL, and pruning command (#1230)

* bump sdk to v0.46.4-pio-1 (#1229)

* Switch to a local version of the sdk (that's mostly what the v0.46-4-pio-1 will be).

* Use the updated server.FlagDisableIAVLFastNode name.

* Update the third-party swagger and then regen the whole thing.

* Bump cosmos-sdk to v0.46.4-pio-1 (from v0.46.3-pio-4).

* make proto-update-deps

* Add changelog entry.

* run codeql on code changes only (#1226)

* run codeql on code changes only

* update changelog

* Add pruning subcommand to provenance root cmd. (#1209)

* Add pruning subcommand to provenance root cmd.

* We already check that a floor gas fee is paid by every tx, hence i think the validation check for min-gas-price is irrelevant now, and an ante handler already checks that flag if some node wants to enforce higher gas price at node/mempool level already.(min_gas_prices_decorator.go)

* Adding changelog.

* Copy the v1.12.2 section from main into the changelog.

* Update changelog and release changelog to reflect v1.13.0-rc4.

Co-authored-by: Ergels Gaxhaj <[email protected]>
Co-authored-by: Arnab Mitra <[email protected]>

* Config update command (#1233) (#1236)

* [1216]: Load the defaults before loading each file.

* [1216]: Add a unit test for the update command.

* [1216]: It turns out that the unpack command is exactly what's needed for update. So Just add that as an alias, and a little extra note in the Long entry for it.

* [1216]: Add changelog entries.

* [1216]: Move the arg checks to the top of runConfigSetCmd.

* [1216]: When loading a FieldValueMap into viper, Instead of loading sectioned keys into viper as the full thing, use a section entry with each sub-key in that. That's how it gets loaded when being read from a file. And since we now want to load the defaults (via FieldValueMap) then, if the file exists, read/load it, we ended up with things in two places. It was either do this or change all the file loading to manually read the file, create FieldValueMaps from it and give that to viper.

* [1216]: Create a DefaultAppConfig that applies our default min-gas-prices to the object and use that instead of serverconfig.DefaultConfig where needed. The result is that all the config stuff no longer thinks the default min-gas-prices is an empty string. Plus, if the app.toml doesn't exist, viper ends up with our default for min-gas-prices too. Also, use the new AsConfigMap for creating the config map in addFieldMapToViper.

* [1216]: Update the config tests (slightly) to account for the default min-gas-prices being what we've defined and add a test to the packed config that makes sure that default is being applied.

* [1216]: In the manager tests, switch to DefaultAppConfig as needed and add a canary for the global-labels special handling.

* [1216]: Add some tests about the min-gas-prices being.

* [1216]: Undo a small change to one of the tests that isn't actually needed (was just for troubleshooting).

* [1216]: Undo another change in the tests that was just from troubleshooting.

* [1216]: Add some unit tests on the AsConfigMap function.

* [1216]: Fix AsConfigMap subsection dup check.

* Bump Cosmos-SDK to v0.46.6-pio-1 (from v0.46.4-pio-1) (#1235) (#1238)

* Bump cosmos-sdk to v0.46.6-pio-1 (from v0.46.4-pio-1).

* Add changelog line.

* Copy the ochre-rc1 upgrade plan to a new ochre plan. Update the ochre-rc1 upgrade plan to not have the msgfees params fix (since it didn't have it when we applied that plan). Create the ochre-rc2 upgrade plan that runs the bank denom-metadata fix migration.

* make proto-update-deps

* Fix the linked PR in the new changelog line.

* Remove the telemetry.global-labels special config-map handling and clean up associated unit tests. That handling is no longer needed because GetConfig has been fixed.

* Fix a unit test that calls NewSendAuthorization which just got changed to take in another parameter.

* Remove the Added module list from the ochre-rc2 upgrade plan since those were added with ochre-rc1. (#1240)

* Mark v1.13.0-rc5 in the changelog and release changelog. (#1239)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Derek Adams <[email protected]>
Co-authored-by: kwt <[email protected]>
Co-authored-by: Carlton Hanna <[email protected]>
Co-authored-by: arnabmitra <[email protected]>
Co-authored-by: Craig Berry <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matt Witkowski <[email protected]>
Co-authored-by: Ergels Gaxhaj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nullpointer0x00 nullpointer0x00 nullpointer0x00 approved these changes

@derekadams derekadams derekadams approved these changes

@iramiller iramiller iramiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SpicyLemon @iramiller @derekadams @nullpointer0x00