Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker denom restrictions #84

Closed
4 tasks
iramiller opened this issue Feb 19, 2021 · 1 comment · Fixed by #123
Closed
4 tasks

Marker denom restrictions #84

iramiller opened this issue Feb 19, 2021 · 1 comment · Fixed by #123
Assignees
Labels
marker Marker Module
Milestone

Comments

@iramiller
Copy link
Member

Summary

In order to prevent spamming the network with denoms of coin that overlap with other well known values [BTC, ETH, etc] the marker module should enforce additional restrictions on coins created directly while keeping the constraints relaxed for governance proposal based coins.

Problem Definition

With any user being able to cheaply and quickly create new coins on the provenance blockchain there is a concern that there maybe confusion from coins being created that trivially match existing currencies on other networks. Despite this concern the flexibility to create coins with short or well known names should be maintained. Using a whitelist or other similar heuristic would also prevent difficulties in maintenance, complexity, and completeness.

Proposal

The simplest solution to the problem appears to be to create a couple new validation parameters for denom names

  • General Validation Expression (set to[a-f].[0-9a-f]{9,39} or similar to allow a hexidecimal denom that does not start with a number and is 10 to 40 in length)
  • Ensure a governance proposal to create a marker is not subject to the above restriction
  • Put the restrictions into parameters that can be configured in genesis or through parameter change proposals

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@iramiller iramiller added the marker Marker Module label Feb 19, 2021
@iramiller iramiller added this to the mainnet Release Candidate milestone Feb 19, 2021
@jdfigure jdfigure modified the milestones: mainnet Release Candidate, Testnet Beta Feb 22, 2021
@iramiller
Copy link
Member Author

It is probably useful to categorize short denoms as "symbols" in user interfaces and related nomenclature. Examples of these would be typical coins and investment fund names. The longer, less restricted names would remain referred to as generic "denoms".

@iramiller iramiller mentioned this issue Mar 2, 2021
8 tasks
@iramiller iramiller modified the milestones: 1.0.0, 0.3.0 Mar 4, 2021
@iramiller iramiller self-assigned this Mar 4, 2021
mtps added a commit that referenced this issue Mar 11, 2021
* Add app to params passed to upgrader plans
* Add default param for new denom restrictions #84
* Move upgrades into app package to avoid import cycles

Co-authored-by: Ira Miller <[email protected]>
@Gabrinthei Gabrinthei mentioned this issue Apr 9, 2021
4 tasks
@iramiller iramiller moved this from Todo to Done in Provenance Core Protocol Team Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
marker Marker Module
Projects
Development

Successfully merging a pull request may close this issue.

2 participants