You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
0.46 provides post transaction handlers, could potentially migrate MsgFeeHandler to that.
Problem Definition
PostHandler are like AnteHandler (they share the same signature), but they execute after [RunMsgs](https://docs.cosmos.network/master/core/baseapp.html#runmsgs).
Like AnteHandlers, PostHandlers are theoretically optional,
Also
Note, when PostHandlers fail, the state from runMsgs is also reverted, effectively making the transaction fail.
So fit's well, may require some finagling on current events being emitted but probably possible?
This would eliminate changes in our cosmos fork, make code easier to maintain etc.
They changed a bunch of stuff around with v0.46 and we need to fix it before we can ship v1.12. #1006 is for doing that.
They also replaced NewMempoolDecorator with NewDeductFeeDecorator. The NewDeductFeeDecorator function takes in a TxFeeChecker (func(ctx sdk.Context, tx sdk.Tx) (sdk.Coins, int64, error)) that might also be leveraged. So there's options.
Summary
0.46 provides post transaction handlers, could potentially migrate MsgFeeHandler to that.
Problem Definition
Also
So fit's well, may require some finagling on current events being emitted but probably possible?
This would eliminate changes in our cosmos fork, make code easier to maintain etc.
Proposal
1.Add posthandler to provenance.
2.Migrate MsgFeeHandler to be a postHandler
For Admin Use
The text was updated successfully, but these errors were encountered: