You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With Cosmos v0.46, there are a bunch of changes to the antehandlers. Those changes don't mesh well with our own decorators.
Proposal
Refactor the NewMsgFeesDecorator, NewTxGasLimitDecorator, NewMsgFeesDecorator, and NewProvenanceDeductFeeDecorator to account for changes made in the SDK, e.g. they changed NewMempoolFeeDecorator into their own NewDeductFeeDecorator.
As part of this, Update internal/handlers/msg_service_router_test.go to remove the t.Skip() calls that prevent the tests from running (because they currently fail).
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
The post handler happens before consumeBlockGas(). But according to our comment in baseapp.go where that's called, we want consumeBlockGas() called BEFORE we try to charge the extra fees.
// When block gas exceeds, it'll panic and won't commit the cached store.
// this should be called before we charge additional fee( otherwise would
// defy the whole point of charging additional fee at the end)
consumeBlockGas()
So we can't use the baseapp, postHandler for these fees.
Summary
Straighten out the msg fee antehandler stuff.
Problem Definition
With Cosmos v0.46, there are a bunch of changes to the antehandlers. Those changes don't mesh well with our own decorators.
Proposal
Refactor the
NewMsgFeesDecorator
,NewTxGasLimitDecorator
,NewMsgFeesDecorator
, andNewProvenanceDeductFeeDecorator
to account for changes made in the SDK, e.g. they changedNewMempoolFeeDecorator
into their ownNewDeductFeeDecorator
.As part of this, Update
internal/handlers/msg_service_router_test.go
to remove thet.Skip()
calls that prevent the tests from running (because they currently fail).For Admin Use
The text was updated successfully, but these errors were encountered: