1256 support for tokens restricted with attributes #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d88da38.
…s check to mult-send
nullpointer0x00
requested review from
SpicyLemon,
EasyEtHP4 and
egaxhaj
and removed request for
EasyEtHP4
SpicyLemon
approved these changes
Mar 17, 2023
SpicyLemon
pushed a commit
that referenced
this pull request
Mar 20, 2023
* add injection of attribute checking...still POC atm * expect restricted function to only return err, refactor names * move send restrictions check to SendCoins * remove line that was missed during refactor * add code comments * move accept logic to msg server * Revert "add code comments" This reverts commit d88da38. * revert ensure restirctions function into send keeper, add restrictions check to mult-send * add back send enable checks to msg server * add change log
19 tasks
SpicyLemon
added a commit
that referenced
this pull request
Mar 21, 2023
…hangelog. (#566) * Merge pull request #564 from provenance-io/egaxhaj/fix-additional-bindings-tags expand additional_bindings so they can be parsed with protobufjs * Merge pull request #565 from provenance-io/egaxhaj/remove-lock-on-state-listening remove listener lock as there is no concurrency * 1256 support for tokens restricted with attributes (#563) * add injection of attribute checking...still POC atm * expect restricted function to only return err, refactor names * move send restrictions check to SendCoins * remove line that was missed during refactor * add code comments * move accept logic to msg server * Revert "add code comments" This reverts commit d88da38. * revert ensure restirctions function into send keeper, add restrictions check to mult-send * add back send enable checks to msg server * add change log * Mark v0.46.10-pio-3 in the changelog and release notes. --------- Co-authored-by: Ergels Gaxhaj <[email protected]> Co-authored-by: Carlton Hanna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for applying send restrictions before a bank send. The related ticket is provenance-io/provenance#1256
Note: The interface will change once provenance-io/provenance#1415 is completed.
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change