Kubeflow README #57
Merged
Kubeflow README #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
usbulat
commented
Jun 17, 2020
usbulat
commented
- added destroy.sh script to destroy all cluster by running one command
- added workaround for "Error: RDS Cluster FinalSnapshotIdentifier is required when a final snapshot is required" in destroy_fix.sh
- added state rm for non-empty s3 bucket for argo-artifacts in destroy_fix.sh - after destroy delete bucket in AWS console if needed
- filled necessary prerequisites to README files
- filled some info about Kubeflow to README files
- added a solution to trigger recreation of Kubeflow terraform resources if changes were made in modules/kubeflow/sak_kustomize folder and kfctl.yaml file
- added script for kfctl installation instead of instruction
- added script for all prerequisites installation
added 6 commits
June 11, 2020 16:01
# Conflicts: # modules/scaling/main.tf
fixed cluster autoscaling module and efs module
# Conflicts: # README.md # example/example.tfvars # example/modules.tf # modules/kubeflow/kfctl.yaml
added workaround for "Error: RDS Cluster FinalSnapshotIdentifier is required when a final snapshot is required" in destroy_fix.sh added state rm for non-empty s3 bucket for argo-artifacts in destroy_fix.sh - after destroy delete bucket in AWS console if needed filled necessary prerequisites to README files filled some info about Kubeflow to README files added a solution to trigger recreation of Kubeflow terraform resources if changes were made in modules/kubeflow/sak_kustomize folder and kfctl.yaml file added script for kfctl installation instead of instruction added script for all prerequisites installation
akastav
approved these changes
Jun 17, 2020
RustamGimadiev
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.