-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/kubernetes 1.18 #129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* terraform 0.14 [modules/cicd/argo/modules/cd] * terraform-aws-modules/iam/aws//modules/iam-assumable-role-with-oidc v.3.6.0 * chart_version 2.11.0 [modules/cicd/jenkins] * change chart repo url [modules/ingress/nginx] * add aws lb tags [modules/ingress/oauth] * change chart repo url [modules/kubernetes] * terraform-aws-modules/eks/aws v13.2.1 * temporary disable enable_irsa option * add cluster_oidc_arn and cluster_output outputs * set 1.18 as default cluster version [modules/logging/efk] * change repo url [modules/network] * terraform-aws-modules/vpc/aws v2.64.0 [modules/scaling/cluster-autoscaler] * terraform-aws-modules/iam/aws//modules/iam-assumable-role-with-oidc v3.6.0 * change repo url [modules/system/external-dns] * terraform-aws-modules/iam/aws//modules/iam-assumable-role-with-oidc v3.6.0 [modules/system/external-secrets] * Fix template * Add namespace creation * Change cluster_output type Signed-off-by: Gleb Rusakov <[email protected]>
gfrntz
force-pushed
the
feature/kubernetes-1.18
branch
from
December 24, 2020 17:42
a283b4c
to
e21bd45
Compare
* terraform 0.14 [modules/cicd/argo/modules/cd] * terraform-aws-modules/iam/aws//modules/iam-assumable-role-with-oidc v.3.6.0 * chart_version 2.11.0 [modules/cicd/jenkins] * change chart repo url [modules/ingress/nginx] * add aws lb tags [modules/ingress/oauth] * change chart repo url [modules/kubernetes] * terraform-aws-modules/eks/aws v13.2.1 * temporary disable enable_irsa option * add cluster_oidc_arn and cluster_output outputs * set 1.18 as default cluster version [modules/logging/efk] * change repo url [modules/network] * terraform-aws-modules/vpc/aws v2.64.0 [modules/scaling/cluster-autoscaler] * terraform-aws-modules/iam/aws//modules/iam-assumable-role-with-oidc v3.6.0 * change repo url [modules/system/external-dns] * terraform-aws-modules/iam/aws//modules/iam-assumable-role-with-oidc v3.6.0 [modules/system/external-secrets] * Fix template * Add namespace creation * Change cluster_output type Update README, delete kubeflow module, add default variables Fix reviewdog terraform version Fix jenkinsfile Add awspec tests for argocd-with-applications
gfrntz
force-pushed
the
feature/kubernetes-1.18
branch
from
December 25, 2020 21:11
ec7386e
to
304bdb8
Compare
akastav
previously approved these changes
Dec 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
RustamGimadiev
previously approved these changes
Dec 28, 2020
akastav
dismissed stale reviews from RustamGimadiev and themself
via
December 28, 2020 08:19
9592eb0
RustamGimadiev
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[examples/argocd-with-applications]
[modules/cicd/argo/modules/cd]
[modules/cicd/jenkins]
[modules/ingress/nginx]
[modules/ingress/oauth]
[modules/kubernetes]
[modules/logging/efk]
[modules/network]
[modules/scaling/cluster-autoscaler]
[modules/system/external-dns]
[modules/system/external-secrets]
Remove kubeflow module
Test
Install ruby
Run
bundle install
Run
terraform plan && terraform apply
Run
AWS_PROFILE=YOUR_PROFILE rake spec