Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Fix reach query not initiating requests for local host #3915

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

Haarolean
Copy link
Contributor

@Haarolean Haarolean commented Jun 7, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
react-query didn't initiate requests even for localhost without active internet access.
Changing network mode to offlineFirst will make it try once and retry in intervals later if the first attempt was unsuccessful.

Resolves #3865

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean added type/bug Something isn't working scope/frontend labels Jun 7, 2023
@Haarolean Haarolean requested a review from a team as a code owner June 7, 2023 08:26
@Haarolean Haarolean self-assigned this Jun 7, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@Mgrdich
Copy link
Contributor

Mgrdich commented Jun 15, 2023

do we have some other layer of caching for our http requests , like Cache-Control header ? or was this intended for containers and java BE already running ?

@Haarolean Haarolean merged commit 2ac8646 into master Jun 16, 2023
@Haarolean Haarolean deleted the issues/3865 branch June 16, 2023 12:25
Haarolean added a commit that referenced this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/frontend type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI is unusable without internet access even for localhost
2 participants