Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] Messages filtering by offset & timestamp doesn't work #3582

Merged
merged 4 commits into from
Apr 10, 2023

Conversation

NeiruBugz
Copy link
Contributor

@NeiruBugz NeiruBugz commented Mar 29, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Resolves #3568
Moved seekType condition to its own variable for easier dive into filtering logic
Update the condition for adding seekTo property to search query
Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@NeiruBugz NeiruBugz requested a review from a team as a code owner March 29, 2023 07:31
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Mar 29, 2023
@NeiruBugz NeiruBugz changed the title SEEK ERROR with all partitions selected when seekType is OFFSET Topics message filter Mar 29, 2023
@NeiruBugz NeiruBugz added type/bug Something isn't working scope/frontend and removed status/triage Issues pending maintainers triage labels Mar 29, 2023
@NeiruBugz NeiruBugz requested a review from workshur March 31, 2023 12:48
@NeiruBugz NeiruBugz self-assigned this Apr 3, 2023
@Haarolean Haarolean changed the title Topics message filter [FE] Messages filtering by offset & timestamp doesn't work Apr 10, 2023
@Haarolean Haarolean self-requested a review April 10, 2023 09:08
@Haarolean Haarolean merged commit 83f9432 into master Apr 10, 2023
@Haarolean Haarolean deleted the bugfix/topic-messages-filter branch April 10, 2023 09:08
@sonarcloud
Copy link

sonarcloud bot commented Apr 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Haarolean pushed a commit that referenced this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/frontend type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Messages filtering by offset & timestamp doesn't work
5 participants