Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added readonly status for the cluster. #1364

Merged
merged 5 commits into from
Jan 17, 2022
Merged

Added readonly status for the cluster. #1364

merged 5 commits into from
Jan 17, 2022

Conversation

NelyDavtyan
Copy link
Contributor

@NelyDavtyan NelyDavtyan commented Jan 10, 2022 •
edited
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing applications:)

What changes did you make? (Give an overview)
Issues #1185
Screen Shot 2022-01-17 at 4 08 26 PM

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "X" next to an item)

  • No need to
  • Manually(please, describe, when necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "X" next to an item, otherwise PR will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings(e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

@workshur
Copy link
Member

@NelyDavtyan Could you add screenshot of your change to description of current PR?

@workshur workshur requested a review from Hurenka January 10, 2022 18:44
@Haarolean Haarolean linked an issue Jan 10, 2022 that may be closed by this pull request
readonly label disappeared from UI #1185
Closed
@Haarolean Haarolean added scope/frontend type/bug Something isn't working type/regression Something that has been previously fixed but got broken again labels Jan 10, 2022
@NelyDavtyan
Classes element changed to styled components.
fb3dcda
@NelyDavtyan
Merge branch 'master' into issues/1185
1f57903 
# Conflicts:
#	kafka-ui-react-app/src/components/Connect/List/__tests__/__snapshots__/ListItem.spec.tsx.snap
#	kafka-ui-react-app/src/components/Schemas/New/__test__/New.spec.tsx
#	kafka-ui-react-app/src/components/Schemas/New/__test__/__snapshots__/New.spec.tsx.snap
#	kafka-ui-react-app/src/components/Topics/Topic/Details/__test__/__snapshots__/Details.spec.tsx.snap
@NelyDavtyan
Merge branch 'master' into issues/1185
8e99993 
# Conflicts:
#	kafka-ui-react-app/src/components/common/Tag/Tag.styled.tsx
@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@NelyDavtyan NelyDavtyan merged commit a4fce3c into master Jan 17, 2022
@NelyDavtyan NelyDavtyan deleted the issues/1185 branch January 17, 2022 14:29
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
@NelyDavtyan
Added readonly status for the cluster. (provectus#1364)
a265996 
* Added readonly status for the cluster.

* Classes element changed to styled components.

* removed unnecessary className from interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hurenka Hurenka Hurenka approved these changes

@Motherships Motherships Motherships approved these changes

@workshur workshur workshur approved these changes

Assignees

@NelyDavtyan NelyDavtyan

Labels
scope/frontend type/bug Something isn't working type/regression Something that has been previously fixed but got broken again
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

readonly label disappeared from UI
5 participants
@NelyDavtyan @workshur @Motherships @Hurenka @Haarolean