Code

feat: connector v1.3 review#88

Code

Open

D-Nice wants to merge 64 commits intomasterprovable-things/ethereum-api:masterfrom feat/connector-v1.3provable-things/ethereum-api:feat/connector-v1.3Copy head branch name to clipboard

+21,579-2,441

Commits

Commits on Jul 3, 2019

• standard fxn formatting

  Show description for 9d134c1
  

  gskapka

  authored and

  D-Nice

  committed
  9d134c1

  Copy full SHA for 9d134c1

• adds getPrice overloads & makes them view

  Show description for df57796
  

  gskapka

  authored and

  D-Nice

  committed
  df57796

  Copy full SHA for df57796

• switch to explicit uint256

  

  gskapka

  authored and

  D-Nice

  committed
  157ba01

  Copy full SHA for 157ba01

• standardizes fxn formatting

  

  gskapka

  authored and

  D-Nice

  committed
  fe0d698

  Copy full SHA for fe0d698

• adds getPrice overloads to connector interface

  

  gskapka

  authored and

  D-Nice

  committed
  c06a0b9

  Copy full SHA for c06a0b9

• fix * spacing

  

  gskapka

  authored and

  D-Nice

  committed
  0cd9334

  Copy full SHA for 0cd9334

• fixes linting isues

  

  gskapka

  authored and

  D-Nice

  committed
  11df7e2

  Copy full SHA for 11df7e2

• adds gasPriceBumping feature to 0.5API

  

  gskapka

  authored and

  D-Nice

  committed
  d2348b3

  Copy full SHA for d2348b3

• adds gasPriceBumping feature to 0.4.25API

  

  gskapka

  authored and

  D-Nice

  committed
  85fed6e

  Copy full SHA for 85fed6e

• adds cached-query feature to 0.4.25 API

  

  gskapka

  authored and

  D-Nice

  committed
  d58b944

  Copy full SHA for d58b944

• adds cached-query feature to 0.4.25 API

  

  gskapka

  authored and

  D-Nice

  committed
  5d84890

  Copy full SHA for 5d84890

• adds parameterized & view getPrice fxns to 0.5 API

  

  gskapka

  authored and

  D-Nice

  committed
  89d1da3

  Copy full SHA for 89d1da3

• adds parameterized & view getPrice fxns to 0.4.25 API

  

  gskapka

  authored and

  D-Nice

  committed
  91369e7

  Copy full SHA for 91369e7

• add spec. for datasource string->byte conversion

  Show description for 22e2f21
  

  gskapka

  authored and

  D-Nice

  committed
  22e2f21

  Copy full SHA for 22e2f21

• updates README w/ currently maintained API versions

  

  gskapka

  authored and

  D-Nice

  committed
  a5e473c

  Copy full SHA for a5e473c

• neatens natspec comments in 0.5 API

  

  gskapka

  authored and

  D-Nice

  committed
  8c4b382

  Copy full SHA for 8c4b382

• amends rebroadcast feat in 0.5 API

  Show description for 806bc13
  

  gskapka

  authored and

  D-Nice

  committed
  806bc13

  Copy full SHA for 806bc13

• amends rebroadcast feat in 0.4.25 API

  Show description for 8a8a575
  

  gskapka

  authored and

  D-Nice

  committed
  8a8a575

  Copy full SHA for 8a8a575

• exposes token payment fxns in 0.4.25 API

  

  gskapka

  authored and

  D-Nice

  committed
  16c02ce

  Copy full SHA for 16c02ce

• exposes token payment fxns in 0.5 API

  

  gskapka

  authored and

  D-Nice

  committed
  7b28e6d

  Copy full SHA for 7b28e6d

• exposes token approval compostions in 0.4.25 API

  

  gskapka

  authored and

  D-Nice

  committed
  ed2c708

  Copy full SHA for ed2c708

• exposes token approval compostions in 0.5 API

  

  gskapka

  authored and

  D-Nice

  committed
  b9a9f14

  Copy full SHA for b9a9f14

• add missing datasource byte spec to 0.4.25 API

  

  gskapka

  authored and

  D-Nice

  committed
  3b047b2

  Copy full SHA for 3b047b2

• add missing datasource byte spec to 0.5 API

  

  gskapka

  authored and

  D-Nice

  committed
  a626675

  Copy full SHA for a626675

• adds bytes datasource query overloads to 0.5 API

  Show description for 498dd9f
  

  gskapka

  authored and

  D-Nice

  committed
  498dd9f

  Copy full SHA for 498dd9f

• switch to using bytes1 explicitly in Oraclize Interface

  

  gskapka

  authored and

  D-Nice

  committed
  5775522

  Copy full SHA for 5775522

• reorder query overloads in 0.5API

  Show description for 6e305d6
  

  gskapka

  authored and

  D-Nice

  committed
  6e305d6

  Copy full SHA for 6e305d6

• adds query overloads w/ dynArgs & byte datasource to 0.5API

  

  gskapka

  authored and

  D-Nice

  committed
  65a557d

  Copy full SHA for 65a557d

• add byte-datasource overloads to interface for 0.4.25API

  

  gskapka

  authored and

  D-Nice

  committed
  0b81ed0

  Copy full SHA for 0b81ed0

• adds bytes version of Oraclize Interface to 0.4.25API

  

  gskapka

  authored and

  D-Nice

  committed
  22147c2

  Copy full SHA for 22147c2

• adds bytes1 overloads of oraclize queries to 0.4.25API

  

  gskapka

  authored and

  D-Nice

  committed
  c1bf8a3

  Copy full SHA for c1bf8a3

• adds bytes1 datasource dynamic arg. query overloads to 0.4.25API

  

  gskapka

  authored and

  D-Nice

  committed
  420b291

  Copy full SHA for 420b291

• brings goerli comment in line with others

  

  gskapka

  authored and

  D-Nice

  committed
  7eba287

  Copy full SHA for 7eba287

• pass value to rebroadcast request in 0.4.25API

  

  gskapka

  authored and

  D-Nice

  committed
  dd03d9a

  Copy full SHA for dd03d9a

• pass value to rebroadcast request in 0.5API

  

  gskapka

  authored and

  D-Nice

  committed
  a490ad1

  Copy full SHA for a490ad1

• adds value param to cachedQuery fxn call in API 0.4.25

  

  gskapka

  authored and

  D-Nice

  committed
  cb65c5b

  Copy full SHA for cb65c5b

• adds value param to cachedQuery fxn call in API 0.5

  

  gskapka

  authored and

  D-Nice

  committed
  0146987

  Copy full SHA for 0146987

• neaten commentary and format per natspec

  

  gskapka

  authored and

  D-Nice

  committed
  4f8bf7e

  Copy full SHA for 4f8bf7e

• unify param formatting in API 0.5

  

  gskapka

  authored and

  D-Nice

  committed
  3b5fc86

  Copy full SHA for 3b5fc86

• format interface fxns per new style guide in API 0.5

  

  gskapka

  authored and

  D-Nice

  committed
  dbb573b

  Copy full SHA for dbb573b

• adds erc20 price getter to connector interface in 0.5 API

  

  gskapka

  authored and

  D-Nice

  committed
  01cdbd6

  Copy full SHA for 01cdbd6

• adds erc20 price getter to connector interface in 0.4.25 API

  

  gskapka

  authored and

  D-Nice

  committed
  c364241

  Copy full SHA for c364241

• add token payment mapping to API 0.4.25

  

  gskapka

  authored and

  D-Nice

  committed
  755cbb3

  Copy full SHA for 755cbb3

• add token payment mapping to 0.5 API

  

  gskapka

  authored and

  D-Nice

  committed
  adb6a66

  Copy full SHA for adb6a66

• adds getERC20Price overloads to 0.5 API

  

  gskapka

  authored and

  D-Nice

  committed
  bf66800

  Copy full SHA for bf66800

• adds getERC20Price overloads to 0.4.25 API

  

  gskapka

  authored and

  D-Nice

  committed
  d8e9fcd

  Copy full SHA for d8e9fcd

• explain need for two interfaces in API 0.4.25

  

  gskapka

  authored and

  D-Nice

  committed
  b8df609

  Copy full SHA for b8df609

• use extant address to save on opcodes when initting bytes interface

  

  gskapka

  authored and

  D-Nice

  committed
  a397081

  Copy full SHA for a397081

• make getPrice overloads view in API 0.4.25

  

  gskapka

  authored and

  D-Nice

  committed
  f68f3a5

  Copy full SHA for f68f3a5

• feat(0.5API): adds entire ERC20 interface

  Show description for 8c64945
  

  gskapka

  authored and

  D-Nice

  committed
  8c64945

  Copy full SHA for 8c64945

• feat(0.5API): adds entire ERC20 interface

  

  gskapka

  authored and

  D-Nice

  committed
  d2d987b

  Copy full SHA for d2d987b

• optimize(0.5API): rm double lookup of connector address via OAR

  

  gskapka

  authored and

  D-Nice

  committed
  0845e8a

  Copy full SHA for 0845e8a

• optimize(0.4API): rm double lookup of connector address via OAR

  

  gskapka

  authored and

  D-Nice

  committed
  452365c

  Copy full SHA for 452365c

• feat(0.5API): adds oraclize_token_query overloads

  Show description for 31e3135
  

  gskapka

  authored and

  D-Nice

  committed
  31e3135

  Copy full SHA for 31e3135

• feat(0.4API): adds oraclize_token_query overloads

  Show description for 16d11cf
  

  gskapka

  authored and

  D-Nice

  committed
  16d11cf

  Copy full SHA for 16d11cf

• fix(0.5API): fixes last remaining compiler warning re pure fxn

  

  gskapka

  authored and

  D-Nice

  committed
  fbda2a0

  Copy full SHA for fbda2a0

• fix(0.4API): revert getPrice views

  Show description for 37d76cd
  D-Nice

  committed
  37d76cd

  Copy full SHA for 37d76cd

• refactor: improve specifier order consistency

  D-Nice

  committed
  b9d4923

  Copy full SHA for b9d4923

• chore(0.5API): use uint256 explicitly where missing

  

  gskapka

  authored and

  D-Nice

  committed
  1ff5a10

  Copy full SHA for 1ff5a10

• chore(0.5API): elucidate address in getPrice fxns

  

  gskapka

  authored and

  D-Nice

  committed
  22af856

  Copy full SHA for 22af856

• chore(0.4.25API): elucidate address in getPrice fxns

  

  gskapka

  authored and

  D-Nice

  committed
  3d358e4

  Copy full SHA for 3d358e4

• chore(copyright): update

  D-Nice

  committed
  bd8deb0

  Copy full SHA for bd8deb0

• feat: update provable api to 1.3

  Show description for 35d8933
  D-Nice

  committed
  35d8933

  Copy full SHA for 35d8933

Commits on Jul 5, 2019

• refactor(style): code review suggestions

  Show description for 211b7b0
  

  D-Nice

  and

  riccardopersiani

  authored
  211b7b0

  Copy full SHA for 211b7b0