Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layer for country boundaries solid lines #45

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

cashc
Copy link
Contributor

@cashc cashc commented Jun 13, 2023

adds a boundaries_country layer for styling country boundaries with a solid line, as opposed to the dashed line that was used for all country/state/province boundaries

@nvkelso
Copy link
Collaborator

nvkelso commented Jun 14, 2023

+1 for creating a separate color theme for these changes. Can that also be in a separate PR than the country lines change, please?

@cashc
Copy link
Contributor Author

cashc commented Jun 14, 2023

@nvkelso done! This PR has been updated to include only the country line change and the theme PR can be seen here #46. Thank you!

@cashc cashc changed the title Theme and layers UI improvements Add layer for country boundaries solid lines Jun 14, 2023
@nvkelso
Copy link
Collaborator

nvkelso commented Jun 14, 2023

Adding the original screenshots here for ease of reference:

before
image

after (ignore the thematic overlay and color changes)
image

Copy link
Collaborator

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for splitting the color changes off to a separate PR :)

@gzurbach
Copy link

gzurbach commented Aug 7, 2023

@bdon is there anything we can do to move this forward? A check is failing but we're not sure if/how we should address it?

We would love to be able to use this new border styling in our maps :)

@bdon bdon merged commit 04a937a into protomaps:main Aug 8, 2023
@bdon
Copy link
Member

bdon commented Aug 8, 2023

@gzurbach thanks for being patient with this - right now I'm in a bit of a bind because:

I have merged this but you are still running "v2" of the tiles, correct? We're moving forward with a v3 of the tiles, but this means that our JS code to generate the style needs to match the breaking changes in tile v3. So having merged this into main it's difficult to get the changes back ported if you are including the style through the NPM package.

The most bulletproof way to work around this is to use JSON in your own application code to define the style, instead of relying on the JS package. Is that something you're doing now?

The downside is that you'll miss out on our improvements to the styles in the near future, so we need to form a change-control strategy around this.

@cashc
Copy link
Contributor Author

cashc commented Aug 8, 2023

@bdon yes, I believe we are still using "v2". And yes, we are using our own custom colors and not relying on the JS package currently. So I think our codebase in a good place. Thanks for the heads up on what migrating to v3 will involve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants