-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add layer for country boundaries solid lines #45
Conversation
+1 for creating a separate color theme for these changes. Can that also be in a separate PR than the country lines change, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for splitting the color changes off to a separate PR :)
@bdon is there anything we can do to move this forward? A check is failing but we're not sure if/how we should address it? We would love to be able to use this new border styling in our maps :) |
@gzurbach thanks for being patient with this - right now I'm in a bit of a bind because: I have merged this but you are still running "v2" of the tiles, correct? We're moving forward with a v3 of the tiles, but this means that our JS code to generate the style needs to match the breaking changes in tile v3. So having merged this into The most bulletproof way to work around this is to use JSON in your own application code to define the style, instead of relying on the JS package. Is that something you're doing now? The downside is that you'll miss out on our improvements to the styles in the near future, so we need to form a change-control strategy around this. |
@bdon yes, I believe we are still using "v2". And yes, we are using our own custom colors and not relying on the JS package currently. So I think our codebase in a good place. Thanks for the heads up on what migrating to v3 will involve! |
adds a
boundaries_country
layer for styling country boundaries with a solid line, as opposed to the dashed line that was used for all country/state/province boundaries