Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bus stops bridges #180

Merged
merged 4 commits into from
Nov 11, 2023
Merged

Bus stops bridges #180

merged 4 commits into from
Nov 11, 2023

Conversation

bdon
Copy link
Member

@bdon bdon commented Nov 11, 2023 •
edited
Loading

Fixes display of bridges shown in #67

Assigns correct pmap:kind to bus stops in #163

@wipfli

Screenshot 2023-11-11 at 08 36 21 Screenshot 2023-11-11 at 08 36 16

bdon added 4 commits November 11, 2023 05:29
@bdon
fix bus stops pmap:kind in POI layer [#163]
48e0281
@bdon
Layer reordering for bridges and water [#67]
19a9347 
* move pedestrian landuse over water
* move water strokes to be just over water polygons
@bdon
spotless
6d9cdf2
@bdon
bump tileset version
53b5a7f
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@bdon bdon merged commit 5df914b into main Nov 11, 2023
5 checks passed
@bdon bdon deleted the bus-stops-bridges branch November 11, 2023 00:48
@wipfli
Copy link
Collaborator

wipfli commented Nov 11, 2023

Looks much better :)

@wipfli
Copy link
Collaborator

wipfli commented Nov 12, 2023

Bridge polygons don't seem to work here:

https://maps.protomaps.com/#map=18.46/47.3601392/8.5233257&theme=light&renderer=maplibregl&tiles=https://build.protomaps.com/20231112.pmtiles

@wipfli
Copy link
Collaborator

wipfli commented Nov 12, 2023

Or here: https://maps.protomaps.com/#map=16.59/47.377647/8.542377&theme=light&renderer=maplibregl&tiles=https://build.protomaps.com/20231112.pmtiles

@bdon
Copy link
Member Author

bdon commented Nov 12, 2023

https://www.openstreetmap.org/way/537126673
https://www.openstreetmap.org/way/300869313

@bdon
Copy link
Member Author

bdon commented Nov 12, 2023

@wipfli do you think those two above need area=yes tags? they are closed ways with man_made=bridge but that is ambiguous whether it is a circular bridge linear feature or a polygon.

bdon added a commit that referenced this pull request Nov 12, 2023
@bdon
don't require man_made=bridge outlines have area=yes [#180]
538ffc0
@bdon bdon mentioned this pull request Nov 12, 2023
Merged
@wipfli
Copy link
Collaborator

wipfli commented Nov 13, 2023

Is there a way to find out how OSM Carto renders bridge polygons? I think we should use the same logic since Carto has probably the largest impact on how people map...

bdon added a commit that referenced this pull request Jan 2, 2024
@bdon
don't require man_made=bridge outlines have area=yes [#180]
0e4e765
bdon added a commit that referenced this pull request Jan 2, 2024
@bdon
don't require man_made=bridge outlines have area=yes [#180] (#182)
65abca7 
* don't require man_made=bridge outlines have area=yes [#180]

* Tiles v3.0.1 - add bridge area example [#182]

* make landuse filters more concise
@bdon
Copy link
Member Author

bdon commented Jan 2, 2024

@wipfli I think it's related to the osm2pgsql Lua tag transform in https://github.com/gravitystorm/openstreetmap-carto/blob/master/openstreetmap-carto.lua

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdon @wipfli