wip multiexpression #109
Closed
wip multiexpression #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdon
commented
Aug 25, 2023
bdon
commented
Aug 25, 2023
bdon
commented
Aug 25, 2023
bdon
commented
Aug 25, 2023
| "State Game Land", "State Park", "Watershed Recreation Unit", "Wild Forest", "Wilderness Area", | ||
| "Wilderness Study Area", "Wildlife Management", "Wildlife Management Area", "Wildlife Sanctuary"); | ||
|
|
||
| // public static Stream<MultiExpression.Entry<String>> US_LANDUSE_KIND = compose( |
nvkelso
reviewed
Aug 25, 2023
| Stream.of(entry("pedestrian", matchAny("man_made", "bridge"))), | ||
| valueEntries("man_made", "pier"), | ||
| valueEntries("natural", "beach"), | ||
| valueEntries("shop", "grocery", "supermarket"), // not in tilezen? |
nvkelso
reviewed
Aug 25, 2023
| // assertKind("airfield", Map.of("military", "airfield")); | ||
| assertKind("golf_course", Map.of("leisure", "golf_course")); | ||
| // assertKind("marina", Map.of("leisure", "marina")); | ||
| assertKind("park", Map.of("leisure", "park")); |
There was a problem hiding this comment.
To test the order of operations, there should at least be one test that includes other tags than just the expected minimum tags... eg add a boundary key-value in.
bdon
force-pushed
the
landuse-multiexpression
branch
from
b5e7f89 to
2273738
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Merged
bdon
force-pushed
the
landuse-multiexpression
branch
2 times, most recently
from
25f9922 to
cb340e8
Compare
|
Kudos, SonarCloud Quality Gate passed! |
bdon
force-pushed
the
landuse-multiexpression
branch
from
cb340e8 to
5265fda
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nvkelso this is a WIP on a refactor of landuse into an expression