Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ newRule ] named-parameters-mapping #403

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

dbale-altoros
Copy link
Collaborator

This rules solves the issue
#397

"
Solidity v0.8.18 was released earlier this week, and one of the newly introduced features are named parameters in mappings. "

@dbale-altoros dbale-altoros changed the title [newRule]] named-parameters-mapping [ newRule ] named-parameters-mapping Feb 16, 2023
@PaulRBerg
Copy link
Contributor

hey @fvictorio, @pfmescher - can we tip you somehow to review this PR? Feel free to drop your ETH address :)

We want to be mindful of your time but the missing support for named mapping params makes Solhint not usable with Solidity v0.8.18

@dbale-altoros dbale-altoros merged commit 48d4f6e into master Feb 17, 2023
@dbale-altoros dbale-altoros deleted the fix/named-parameters-in-mappings branch February 17, 2023 14:36
@PaulRBerg
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants