-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hotfix] - Fix Earn values of emails #50
Merged
mariano-aguero
merged 25 commits into
development
from
hotfix/fix-earnings-notifications
Jun 28, 2019
Merged
[Hotfix] - Fix Earn values of emails #50
mariano-aguero
merged 25 commits into
development
from
hotfix/fix-earnings-notifications
Jun 28, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also extracted the check of getDidDelegateCallReward in a function
…lClaimRewardCall => sendDelegateEmail Exported function to sendEmail to utils -> sendEmail(msg); now both sendDelegateEmail and sendDelegateEmail functions creates the mail msg and clals this function instead of duplicating it Also removes logic of getting delegator, subscribers, called reward, rounds, etc from the createDelegatorNotificationEmail, now that function directly receives that data
…lClaimRewardCall => sendDelegateEmail Also removes logic of getting delegator, subscribers, called reward, rounds, etc from the createDelegatorNotificationEmail, now that function directly receives that data Fixes imports, wrong calls
Agupane
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect #44
Completed tasks:
Get instant alert action
Email notification with the fix update:
Telegram notification with the fix update: