Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] - Fix Earn values of emails #50

Merged
merged 25 commits into from
Jun 28, 2019

Conversation

mariano-aguero
Copy link
Contributor

@mariano-aguero mariano-aguero commented Jun 27, 2019

Connect #44

Completed tasks:

  • Fix earning calculation
  • Add improvement for telegram bot related to Get instant alert action
  • Integration of graph services

Email notification with the fix update:
Screenshot_20190626_110427

Telegram notification with the fix update:
Screenshot_20190626_110326

@mariano-aguero mariano-aguero self-assigned this Jun 27, 2019
Also extracted the check of getDidDelegateCallReward in a function
…lClaimRewardCall => sendDelegateEmail

Exported function to sendEmail to utils -> sendEmail(msg); now both sendDelegateEmail and sendDelegateEmail functions creates the mail msg and clals this function instead of duplicating it

Also removes logic of getting delegator, subscribers, called reward, rounds, etc from the createDelegatorNotificationEmail, now that function directly receives that data
…lClaimRewardCall => sendDelegateEmail

Also removes logic of getting delegator, subscribers, called reward, rounds, etc from the createDelegatorNotificationEmail, now that function directly receives that data
Fixes imports, wrong calls
@mariano-aguero mariano-aguero merged commit 7d6b690 into development Jun 28, 2019
@mariano-aguero mariano-aguero deleted the hotfix/fix-earnings-notifications branch June 28, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants