-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Feature) Top delegates #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tests for both calculateRoi and calculateMissedRewardCalls functions
Adds tests for both calculateRoi and calculateMissedRewardCalls functions
# Conflicts: # server/delegate/delegate.controller.js # server/helpers/delegate.js
Fixs sorting of top delegates Fixs inflationRate fn call
…gateService Fixs topDelegates calculation Adds getDelegateRewards and getDelegateTotalStake functions on delegateService Adds check of active transcoder in getRegisteredDelegates Removes units conversions on protocol.js file, should be done outside Adds null parameter on tokenAmountInUnits
Agupane
changed the base branch from
development
to
feature/sdk-graphql-refactoring
June 25, 2019 19:43
Agupane
changed the base branch from
feature/sdk-graphql-refactoring
to
development
June 25, 2019 19:44
# Conflicts: # server/helpers/services/delegateService.js
@Agupane I think we need to do:
|
# Conflicts: # server/helpers/services/delegateService.js Fixs wrong method getDelegate call
…alerts-backend into feature/topDelegates
mariano-aguero
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #41
Depends on #42
Closes #58
Description
Let the user to get the top "x" transcoders based on their
ROI
valueROI Calculation:
Represent the amount of LPT that a delegator will obtain each round he bonds to a delegator.
The return of investments (ROI) is calculated always for the next round. It's calculated using a totalBonded stake of 1000, so, it's the value that a delegator will obtain for the next round is he bonds 1000 LPT to that transcoder
ROI = rewardsToDelegatorsForNextRound*delegatorParticipationInBondedStakeRatio
RewardsToDelegatorsForNextRound = delegateRewardsForNextRound * (1-delegateRewardCut)
DelegateRewardsForNextRound = mintedTokensForNextRound * delegateParticipationInTotalBonded
Example: