(Feature) Fixs check round change job related to circular dependencies #126

Agupane · 2019-08-01T14:29:37Z

Closes #108

Replaces sdk call to getLivepeerDefaultConstants with constants
Fixs bug on sendDelegatorNotificationBondingPeriodHasEnded in which the function truncateStringInTheMiddle was called without require
Fixs getSubscriptorRole, now the promiseRetry is gone, and the promise all was replaces with two different awaits. If an error occurs on getDelegatorAccount it throws an exception

Adds logs Adds try catch

…legators

Agupane added 4 commits August 1, 2019 11:21

Removes promise retrys on getSubscriptorRole

f3ce4ca

Adds logs Adds try catch

Replaces sdk calls of getLivepeerDefaultConstants with constants

fc4b7e0

Fixs sendDelegatorNotificationBondingPeriodHasEnded import

8e965dc

Adds try catch on sendEmailAfterBondingPeriodHAsEndedNotificationToDe…

db33642

…legators

Agupane requested a review from mariano-aguero August 1, 2019 14:29

Agupane self-assigned this Aug 1, 2019

Agupane changed the title ~~(Feature) fixs circular dependencies~~ (Feature) Fixs check round change job related to circular dependencies Aug 1, 2019

mariano-aguero approved these changes Aug 1, 2019

View reviewed changes

mariano-aguero merged commit 54f6a76 into development Aug 1, 2019

mariano-aguero deleted the hotfix/circularDependencies2 branch August 1, 2019 15:42

Provide feedback