Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]Be notified when the UNBONDING > UNBONDED period has ended #116

Merged
merged 4 commits into from
Jul 30, 2019

Conversation

mariano-aguero
Copy link
Contributor

Closes #74

The UNBONDING to UNBONDED notification already exist, I attach some images:
Screenshot_20190726_165515

I added a validation for the UNBONDED state, only one email can be delivered to the user in that case.

@mariano-aguero mariano-aguero self-assigned this Jul 26, 2019
Copy link
Contributor

@Agupane Agupane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logics seems ok, but please add some tests, thanks!

@mariano-aguero
Copy link
Contributor Author

The logics seems ok, but please add some tests, thanks!

I added a couple of tests,

Regards

@Agupane Agupane merged commit b64331c into development Jul 30, 2019
@Agupane Agupane deleted the feature/restrict-unbonded-notification-to-one branch July 30, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]Be notified when the UNBONDING > UNBONDED period has ended
2 participants