(Feature) Sdk graphql refactoring #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds unitAmountInTokenUnits utils file
Adds createDelegator utils file Adds tests for getDelegateProtocolNextReward, getDelegateNextReward, getDelegateRewardToDelegators, getDelegatorNextReturn, getMissedRewardCalls
…ested on the delegate test file
… the tests related to the SDK
…ance on querys Adds delegatorService and protocolService with configurable source -> use dependencies injection accept receiving a dataSource (graphql or sdk) for data fetching
Merged
Fixs imports
Fixs wrong function calls Updates service dependencies on sendEmailClaimRewardCall.js Remoes promise retry from load subscriber, now should be done on the sdk
Removes travis_wait
Merged
…ey should be done on the protocolService Fixes wrong method name
Adds getDelegateRewards on delegateService.js Adds getDelegateTotalStake on delegateService.js Fixs tests
mariano-aguero
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #41
Description
Now the
LivepeerAPI.jsfile was divided into three different services:Each service implements the same logic but using dependency inyection, each one of them could receive the source of the data (graphql or sdk) and use those implementations
The implementations are on
./sdkand./graphqlNote: the
protocolServiceimplements a cache that will be updated periodically using a constant. This will improve the performance of most of the callsThe idea is to abstract the usage of the sdk/graphql to the other functions, if we later on, replace all the sdk implementations with graphql, is simple as change the source of the data on the service
I have also added
--harmonyflag on node run script in order to enable ES6