Skip to content

Commit

Permalink
Explicitly drop support for python on Windows.
Browse files Browse the repository at this point in the history
This was already broken, but wasn't caught in tests because `python3` wasn't defined on our windows machines.  To prevent it from breaking the entire downstream Bazel workspace when `python3` exists, we mark it unsupported.

PiperOrigin-RevId: 506318286
  • Loading branch information
mkruskal-google authored and copybara-github committed Feb 1, 2023
1 parent f8a3e0d commit 008a9af
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions bazel/system_python.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,10 @@ def _populate_package(ctx, path, python3, python_version):
if int(python_version[idx]) < int(v):
supported = False
break
if "win" in ctx.os.name:
# buildifier: disable=print
print("WARNING: python is not supported on Windows")
supported = False

build_file = _build_file.format(
interpreter = python3,
Expand Down

0 comments on commit 008a9af

Please sign in to comment.